-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update setup.py and MANIFEST.in to include environment files and add … #38
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- pre-commit checks need to be fixed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have more comments regarding this PR, it is generally ok, but some stuff seems to be unnecessary addition.
I don't have the right to approve workflows for this repo; should I ask someone? Or will you do it @atstarke? |
- Resolved whitespace and pre-commit errors in gridworld.py and gen_mds.py.
0275988
to
216a869
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All looks good!
Provides fix for issue #14
-Fixed pip install issues. Updates to setup.py and MANIFEST.in
-Now, pip installing should ensure that the environments are included in the library's installation.