Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change in screen resolution #49

Merged
merged 1 commit into from
Nov 4, 2024

Conversation

JoseLuisC99
Copy link
Contributor

@JoseLuisC99 JoseLuisC99 commented Oct 8, 2024

As I mentioned in #47, I am working on integrating MAgent2 into BenchMARL, however, I encountered a bug while rendering the video during test time. When torchrl tries to encode the mp4 video from a set of frames using the libx264 codec, it throws the error height not divisible by 2.

The easiest way to solve it is to simply increase the height by one pixel in MAgent2.

cc: @atstarke

@atstarke atstarke merged commit b2ddd49 into Farama-Foundation:main Nov 4, 2024
11 checks passed
@atstarke
Copy link
Collaborator

atstarke commented Nov 4, 2024

Merged, apologies for the delay.

@JoseLuisC99 JoseLuisC99 deleted the renderer-change branch November 6, 2024 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants