Skip to content

Commit

Permalink
Remove atari tests and update test ignore warnings
Browse files Browse the repository at this point in the history
  • Loading branch information
pseudo-rnd-thoughts committed Mar 7, 2024
1 parent 2be5850 commit ec98dfb
Show file tree
Hide file tree
Showing 7 changed files with 4 additions and 61 deletions.
19 changes: 0 additions & 19 deletions .github/workflows/optional-test-atari.yml

This file was deleted.

37 changes: 0 additions & 37 deletions bin/atari.Dockerfile

This file was deleted.

2 changes: 1 addition & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ def get_version():
],
"dm-lab": ["dm-env>=1.6"],
"openspiel": ["open_spiel>=1.2", "pettingzoo>=1.23"],
"meltingpot": ["pettingzoo>=1.23", "dm-meltingpot>=2.2.0; python_version > '3.9'"],
"meltingpot": ["pettingzoo>=1.23", "dm-meltingpot>=2.2.0; python_version > '3.9'", "chex>=1.85"],
"bsuite": ["bsuite>=0.3.5"],
}
extras["all"] = [
Expand Down
2 changes: 1 addition & 1 deletion tests/test_bsuite.py
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ def test_bsuite_suite_envs():
f"\x1b[33mWARN: {message}\x1b[0m"
for message in [
"A Box observation space minimum value is -infinity. This is probably too low.",
"A Box observation space maximum value is -infinity. This is probably too high.",
"A Box observation space maximum value is infinity. This is probably too high.",
"A Box observation space has an unconventional shape (neither an image, nor a 1D vector). We recommend flattening the observation to have only a 1D vector or use a custom policy to properly process the data. Actual observation shape: (28, 28)",
"A Box observation space has an unconventional shape (neither an image, nor a 1D vector). We recommend flattening the observation to have only a 1D vector or use a custom policy to properly process the data. Actual observation shape: (42, 42)",
"A Box observation space has an unconventional shape (neither an image, nor a 1D vector). We recommend flattening the observation to have only a 1D vector or use a custom policy to properly process the data. Actual observation shape: (10, 5)",
Expand Down
2 changes: 1 addition & 1 deletion tests/test_dm_control.py
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ def test_dm_control_suite_envs():
f"\x1b[33mWARN: {message}\x1b[0m"
for message in [
"A Box observation space minimum value is -infinity. This is probably too low.",
"A Box observation space maximum value is -infinity. This is probably too high.",
"A Box observation space maximum value is infinity. This is probably too high.",
"For Box action spaces, we recommend using a symmetric and normalized space (range=[-1, 1] or [0, 1]). See https://stable-baselines3.readthedocs.io/en/master/guide/rl_tips.html for more information.",
"A Box observation space has an unconventional shape (neither an image, nor a 1D vector). We recommend flattening the observation to have only a 1D vector or use a custom policy to properly process the data. Actual observation shape: ()",
"A Box observation space has an unconventional shape (neither an image, nor a 1D vector). We recommend flattening the observation to have only a 1D vector or use a custom policy to properly process the data. Actual observation shape: (8, 2)",
Expand Down
2 changes: 1 addition & 1 deletion tests/test_gym.py
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
for message in [
"This version of the mujoco environments depends on the mujoco-py bindings, which are no longer maintained and may stop working. Please upgrade to the v4 versions of the environments (which depend on the mujoco python bindings instead), unless you are trying to precisely replicate previous works).",
"A Box observation space minimum value is -infinity. This is probably too low.",
"A Box observation space maximum value is -infinity. This is probably too high.",
"A Box observation space maximum value is infinity. This is probably too high.",
"For Box action spaces, we recommend using a symmetric and normalized space (range=[-1, 1] or [0, 1]). See https://stable-baselines3.readthedocs.io/en/master/guide/rl_tips.html for more information.",
"The environment CartPole-v0 is out of date. You should consider upgrading to version `v1`.",
]
Expand Down
1 change: 0 additions & 1 deletion tests/test_meltingpot.py
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@

pytest.importorskip("meltingpot")

import meltingpot
from meltingpot.substrate import SUBSTRATES

from shimmy.meltingpot_compatibility import MeltingPotCompatibilityV0
Expand Down

0 comments on commit ec98dfb

Please sign in to comment.