Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NPM publish on GitHub releases #110

Merged
merged 3 commits into from
Oct 23, 2023
Merged

NPM publish on GitHub releases #110

merged 3 commits into from
Oct 23, 2023

Conversation

szaldivar
Copy link
Collaborator

  • @FedericoTartarini This requires the repository to have a secret called NPM_TOKEN with the NPM token.
  • This PR will make it so that when we create a release using the GitHub release system, it will also trigger a publish to NPM. (I like this pattern since it means that we will see all the releases in the repository for quick access, and they will be synced with NPM releases.)
  • Bumping the version to 0.1.0

Lu-Whale
Lu-Whale approved these changes Oct 22, 2023
View reviewed changes
Copy link
Collaborator

@Lu-Whale Lu-Whale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@FedericoTartarini
Copy link
Owner

Sure this is a great idea. I have already added the NPM_TOEKEN environmental variable to the project. Is there anything else I need to do?

@szaldivar
Copy link
Collaborator Author

Great! I don't think there is anything else. I will test it out and let you know

@szaldivar szaldivar merged commit a1db4f0 into main Oct 23, 2023
@szaldivar szaldivar deleted the sz/npm-publish branch October 23, 2023 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lu-Whale Lu-Whale Lu-Whale approved these changes

@FedericoTartarini FedericoTartarini Awaiting requested review from FedericoTartarini

@jordanocokoljic jordanocokoljic Awaiting requested review from jordanocokoljic

@Ilite-Kiriya Ilite-Kiriya Awaiting requested review from Ilite-Kiriya

@YuchenMu YuchenMu Awaiting requested review from YuchenMu

@oacuache oacuache Awaiting requested review from oacuache

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@szaldivar @FedericoTartarini @Lu-Whale