Fix issues with JOS3, migrate most functions to use math.Matrix instead of plain arrays
#125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note, some tests are broken - this is expected as the types have become incompatible.
Excluding JOS3 - this will come in a later commit
JOS3 for `dict_result` are finally in!
Includes `body_names` and `results`
|
On checking, the library is currently published under |
FedericoTartarini
approved these changes
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a standing issue in JOS3 that would prevent it from running more than one simulation run.
As a consequence, many of the functions that JOS3 relies on have been updated to accept and return
mathjsMatrixinstances, as they provide much better flexibility for common mathematical operations.Therefore, the next publication of the library should be to a 2.x version.