6.0/2923 Make serialization use new serializers #3002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Also made sure ITypedElement.ToXml() sticks to old behaviour for subtree serialization. * Removed BaseFhirSerializer.
ewoutkramer
changed the title
…the main serializers.
Made the obsolete Newtonsoft function work via the new serializers Removed subsetting functions from the POCO surface.
mmsmits
requested changes
Jan 9, 2025
| @@ -21,7 +21,6 @@ | |||
| <Compile Include="$(MSBuildThisFileDirectory)Snapshot\SnapshotElementMatcherTests.cs" /> | |||
| <Compile Include="$(MSBuildThisFileDirectory)Snapshot\SnapshotGeneratorManifestTests.cs" /> | |||
| <Compile Include="$(MSBuildThisFileDirectory)Snapshot\SnapshotGeneratorTest.cs" /> | |||
| <Compile Include="$(MSBuildThisFileDirectory)Snapshot\SnapshotGeneratorTypeSlicingTests.cs" /> | |||
|
I have now documented all serialization functions and extensions, as requested verbally by @mmsmits. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2923.
I have not yet done some renames because it would make reviewing harder. So after review, this still needs to be done: