Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove NameSpace usage #434

Merged
merged 1 commit into from
Jan 23, 2025
Merged

Remove NameSpace usage #434

merged 1 commit into from
Jan 23, 2025

Conversation

0x45f
Copy link
Collaborator

@0x45f 0x45f commented Jan 23, 2025

PR Category

Other

Type of Change

Other

Description

Remove NameSpace usage

Issue

Progress

  • Change is properly reviewed (1 reviewer required, 2 recommended).
  • Change is responded to an issue.
  • Change is fully covered by a UT.

Performance

iclementine
iclementine approved these changes Jan 23, 2025
View reviewed changes
Copy link
Collaborator

@iclementine iclementine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Note: Namespace was intended for avoiding name conflict, mainly in the case of inlining code into a larger scope. Since inlining is not involved in those ops, it is saver & clearer to remove them.

@iclementine iclementine merged commit a2e9ce6 into FlagOpen:master Jan 23, 2025
9 checks passed
@0x45f 0x45f deleted the rm-namespace branch January 24, 2025 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iclementine iclementine iclementine approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@0x45f @iclementine