Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Seach Unicode plugin set #444

Merged
merged 4 commits into from
Jan 19, 2025

Conversation

blueset
Copy link
Contributor

@blueset blueset commented Jan 13, 2025

@jjw24
Copy link
Member

jjw24 commented Jan 18, 2025

Hi there, how's it going?

Could you please confirm where the uni.exe file is downloaded from https://github.com/blueset/flow-search-unicode/blob/master/uni.exe. Could you please use the GitHub workflow or the release.ps1to down this file instead, so that others can confirm the source of this exe.

Let me know if you need further assistance with this :)

@blueset
Copy link
Contributor Author

blueset commented Jan 18, 2025

Updated the repo and pipeline to retrieve uni.exe at build time instead of bundling in git repo.

Please find the download script here: https://github.com/blueset/flow-search-unicode/blob/master/get-uni.ps1

@jjw24
Copy link
Member

jjw24 commented Jan 18, 2025

Awesome, thanks for fixing that up. I forgot to mention if you ever wanted to actually handle it in your code instead of a standalone script so that when you develop locally the file gets downloaded as well without having to separately run the script, you can have a look at my Droplex library. The Explorer plugin as an example uses it to download and extract the Everything service.

@jjw24 jjw24 enabled auto-merge January 19, 2025 00:00
@jjw24 jjw24 merged commit 217c2d6 into Flow-Launcher:plugin_api_v2 Jan 19, 2025
5 checks passed
@blueset
Copy link
Contributor Author

blueset commented Jan 19, 2025

Thanks for the suggestion! If I understand correctly, Droplex is like a combination of a subset of a package manager and software repository that exposes a C# API. In the case of my plugins, since uni distributes as a portable binary, the installation process would simply be download and unzip. Ideally I hope to hand over binary dependencies to winget which is shipped with Windows 11 to avoid having multiple copies of the same binary in file system, but currently its community repository doesn’t allow portable software lacking a binary installer.

@jjw24
Copy link
Member

jjw24 commented Jan 20, 2025

If I understand correctly, Droplex is like a combination of a subset of a package manager and software repository that exposes a C# API.

Yes, pretty much a package manager that lives with the application code and exposes an API for easily managing silent installs and zip extraction. The goal of Droplex is to enable the application to install its required third party services independent of a package manager.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants