-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial implementation #1
Conversation
0f838f1
to
19f4c7e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There have been some changes in the starter since this repository was created. See https://github.com/FlowingCode/AddonStarter24/compare/ae1a92b1...b859384
Checklist for the initial commitGeneral
POM
README
ISSUE_TEMPLATE
License
Documentation
Demos
Tests
CI
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Template Add-on" has not been replaced with the actual full name of the add-on in both Bug Report and Feature Request templates.
src/main/java/com/flowingcode/vaadin/addons/markdown/BaseMarkdownComponent.java
Outdated
Show resolved
Hide resolved
src/main/java/com/flowingcode/vaadin/addons/markdown/BaseMarkdownComponent.java
Outdated
Show resolved
Hide resolved
src/main/java/com/flowingcode/vaadin/addons/markdown/MarkdownEditor.java
Outdated
Show resolved
Hide resolved
src/main/java/com/flowingcode/vaadin/addons/markdown/MarkdownEditor.java
Outdated
Show resolved
Hide resolved
src/main/java/com/flowingcode/vaadin/addons/markdown/MarkdownViewer.java
Show resolved
Hide resolved
src/main/java/com/flowingcode/vaadin/addons/markdown/MarkdownViewer.java
Outdated
Show resolved
Hide resolved
src/main/java/com/flowingcode/vaadin/addons/markdown/MarkdownViewer.java
Show resolved
Hide resolved
src/main/java/com/flowingcode/vaadin/addons/markdown/MarkdownViewer.java
Outdated
Show resolved
Hide resolved
src/main/java/com/flowingcode/vaadin/addons/markdown/BaseMarkdownComponent.java
Show resolved
Hide resolved
src/main/java/com/flowingcode/vaadin/addons/markdown/MarkdownEditor.java
Outdated
Show resolved
Hide resolved
src/main/java/com/flowingcode/vaadin/addons/markdown/MarkdownEditor.java
Show resolved
Hide resolved
/** | ||
* Colors schemes for the Markdown component | ||
*/ | ||
public enum DATA_COLOR_MODE {DARK,LIGTH,AUTO}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Why is the enum class UPPERCASE?
- Enum constants have no documentation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done ✔️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Enum constants have no documentation
19f4c7e
to
6a9eb9a
Compare
Warning Rate limit exceeded@mlopezFC has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 2 minutes and 58 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. WalkthroughThe changes in this pull request encompass a comprehensive rebranding of the project from "Template Add-on" to "Markdown Editor Add-on." This includes updates to various files such as issue templates, README, POM configuration, and multiple Java classes and test files. New components for Markdown editing and viewing have been introduced, along with corresponding styles and integration tests. The modifications also involve renaming packages, classes, and updating dependencies to align with the new project focus. Changes
Note 🎁 Summarized by CodeRabbit FreeYour organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Pro by visiting https://app.coderabbit.ai/login. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
6a9eb9a
to
d77c1fd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixes look okay to me but I just notice the Readme needs update on the "Getting started" section.
Also the checklist expects in this stage to have the component added to AddonsDemo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Upgrade maven-javadoc-plugin to 3.10.0
/** | ||
* Colors schemes for the Markdown component | ||
*/ | ||
public enum DATA_COLOR_MODE {DARK,LIGTH,AUTO}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Enum constants have no documentation
d77c1fd
to
6aefad7
Compare
2bb4e31
to
9afb6f7
Compare
9afb6f7
to
769d38f
Compare
Summary by CodeRabbit
Release Notes
New Features
Improvements
Chores