[FEATURE] Introduce ResourceFactory proxy

Necessary because of upcoming core changes that make the
class final.

Classes/Form/Transformation/Transformer/FileTransformer.php

@@ -15,13 +15,13 @@
 use FluidTYPO3\Flux\Form\FormInterface;
 use FluidTYPO3\Flux\Form\OptionCarryingInterface;
 use FluidTYPO3\Flux\Form\Transformation\DataTransformerInterface;
+use FluidTYPO3\Flux\Proxy\ResourceFactoryProxy;
 use FluidTYPO3\Flux\Utility\DoctrineQueryProxy;
 use FluidTYPO3\Flux\Utility\ExtensionConfigurationUtility;
 use TYPO3\CMS\Core\Database\ConnectionPool;
 use TYPO3\CMS\Core\Resource\Exception\ResourceDoesNotExistException;
 use TYPO3\CMS\Core\Resource\File;
 use TYPO3\CMS\Core\Resource\FileReference;
-use TYPO3\CMS\Core\Resource\ResourceFactory;
 
 /**
  * File Transformer
@@ -30,9 +30,9 @@
 class FileTransformer implements DataTransformerInterface
 {
     private ConnectionPool $connectionPool;
-    private ResourceFactory $resourceFactory;
+    private ResourceFactoryProxy $resourceFactory;
 
-    public function __construct(ConnectionPool $connectionPool, ResourceFactory $resourceFactory)
+    public function __construct(ConnectionPool $connectionPool, ResourceFactoryProxy $resourceFactory)
     {
         $this->connectionPool = $connectionPool;
         $this->resourceFactory = $resourceFactory;

Classes/Proxy/ResourceFactoryProxy.php

@@ -0,0 +1,32 @@
+<?php
+namespace FluidTYPO3\Flux\Proxy;
+
+/*
+ * This file is part of the FluidTYPO3/Flux project under GPLv2 or later.
+ *
+ * For the full copyright and license information, please read the
+ * LICENSE.md file that was distributed with this source code.
+ */
+
+use TYPO3\CMS\Core\Resource\FileReference;
+use TYPO3\CMS\Core\Resource\ResourceFactory;
+
+/**
+ * Final/readonly class is unnecessary coercion - and using it in shared libraries is arrogant and very disrespectful.
+ *
+ * @codeCoverageIgnore
+ */
+class ResourceFactoryProxy
+{
+    private ResourceFactory $resourceFactory;
+
+    public function __construct(ResourceFactory $resourceFactory)
+    {
+        $this->resourceFactory = $resourceFactory;
+    }
+
+    public function getFileReferenceObject(int $uid): FileReference
+    {
+        return $this->resourceFactory->getFileReferenceObject($uid);
+    }
+}

Tests/Unit/Form/Transformation/Transformer/FileTransformerTest.php

@@ -12,20 +12,20 @@
 use FluidTYPO3\Flux\Enum\FormOption;
 use FluidTYPO3\Flux\Form;
 use FluidTYPO3\Flux\Form\Transformation\Transformer\FileTransformer;
+use FluidTYPO3\Flux\Proxy\ResourceFactoryProxy;
 use FluidTYPO3\Flux\Tests\Mock\QueryBuilder;
 use FluidTYPO3\Flux\Tests\Unit\AbstractTestCase;
 use TYPO3\CMS\Core\Database\ConnectionPool;
 use TYPO3\CMS\Core\Resource\Exception\ResourceDoesNotExistException;
 use TYPO3\CMS\Core\Resource\FileReference;
-use TYPO3\CMS\Core\Resource\ResourceFactory;
 use TYPO3\CMS\Extbase\Domain\Model\FrontendUser;
 use TYPO3\CMS\Extbase\Domain\Repository\FrontendUserGroupRepository;
 use TYPO3\CMS\Extbase\Domain\Repository\FrontendUserRepository;
 
 class FileTransformerTest extends AbstractTestCase
 {
     private ConnectionPool $connectionPool;
-    private ResourceFactory $resourceFactory;
+    private ResourceFactoryProxy $resourceFactory;
     private FileTransformer $subject;
 
     protected function setUp(): void
@@ -35,7 +35,7 @@ protected function setUp(): void
             ->disableOriginalConstructor()
             ->getMock();
 
-        $this->resourceFactory = $this->getMockBuilder(ResourceFactory::class)
+        $this->resourceFactory = $this->getMockBuilder(ResourceFactoryProxy::class)
             ->onlyMethods(['getFileReferenceObject'])
             ->disableOriginalConstructor()
             ->getMock();