Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update Duel.Overlay #479

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

mercury233
Copy link
Collaborator

Requires Fluorohydride/ygopro#2468

Problem 1:
All operations in YGOPro which make Xyz monster leave the field will handle xyz materials automatically,
but Duel.Overlay won't, you must do this in script, it is strange since if you want to overlay the xyz materials to the new monster (effect of Number 75: Bamboozling Gossip Shadow) you should use Duel.Overlay to the xyz materials ahead.

local og=tc:GetOverlayGroup()
if og:GetCount()>0 then
	Duel.SendtoGrave(og,REASON_RULE)
end
Duel.Overlay(c,Group.FromCards(tc))

Problem 2:
If we change the order of Duel.SendtoGrave and Duel.Overlay in the above script, the YGOPro client will crash, because it can't find the overlay handler to deattach from.

Problem 3:
If Number 101: Silent Honor ARK select Kashtira Arise-Heart to attach, the xyz materials of Arise-Heart should be sent to grave after Arise-Heart is attached, so them shouldn't be redirected to banish.
But now in YGOPro them will be banished because Duel.SendtoGrave is called before Duel.Overlay.

libduel.cpp Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants