Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FunctionalAligner #42

Merged

Conversation

angelosilvestre
Copy link
Collaborator

Add FunctionalAligner

This PR introduces FunctionalAligner , which is a FollowerAligner that delegates to a callback.

Copy link
Collaborator

@matthew-carroll matthew-carroll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@matthew-carroll
Copy link
Collaborator

@angelosilvestre do you know what's going on with the goldens?

@angelosilvestre
Copy link
Collaborator Author

@matthew-carroll It seems that, with Material 3, the default background color changed, causing the tests to fail.

I updated the goldens.

Copy link
Collaborator

@matthew-carroll matthew-carroll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@matthew-carroll matthew-carroll merged commit 8cffc3f into Flutter-Bounty-Hunters:main Nov 23, 2023
2 checks passed
@angelosilvestre angelosilvestre deleted the functional_aligner branch November 23, 2023 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants