Remove logging string interpolations from hot path #45
Conversation
| @@ -387,7 +387,8 @@ class RenderFollower extends RenderProxyBox { | |||
| return; | |||
| } | |||
|
|
|||
| FtlLogs.follower.finest("Follower's LeaderLink reported a change: $_link. Requesting Follower child repaint."); | |||
There was a problem hiding this comment.
This solution might also add some GC pressure / jank since it will create extra closures that are never used. Maybe we just do:
if (FtlLogs.follower.isLoggable(Level.FINEST)) {
FtlLogs.follower.finest("Follower's LeaderLink reported a change: $_link. Requesting Follower child repaint.");
}
WDYT? Not sure, adds a bit of extra cpu pressure for potential savings on memory pressure (and eventually gc pressure).
There was a problem hiding this comment.
The extra closures have been issue in the element visitor, but I haven't seen it in profile here. There are much less invocations I'd assume.
It won't hurt but I don't think it's worth complicating the code except in tight loops (i.e. _collectTransformForLayerChain).
|
@matthew-carroll Ping on the follow the leader performance improvement |
|
@knopp - Do you know if the widget state properties are now in stable? If so, can you update the handful of analysis errors? |
Seems like it. I'll make another PR. |
|
I merged the other PR. Please rebase this one. |
knopp
force-pushed
the
string_interpolations_hot_path
branch
from
d87e2df to
d7e3920
Compare
matthew-carroll
merged commit 8106677
into
Flutter-Bounty-Hunters:main
No description provided.