Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CONTRIBUTING.md and PROJECT_ARCHITECTURE.md #6

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Vanethos
Copy link
Collaborator

@Vanethos Vanethos commented May 5, 2019

Fix for #3
Add CONTRIBUTING.md and PROJECT_ARCHITECTURE.md

@OldMetalmind
Copy link
Member

  • We should also mention that any non-code type of pull requests are welcome, such as, designs, copywriting, translations and documentation edits.
  • There is an error with "enhanchement" -> enhancement

A topic for discussion:

  • Shouldn't we also ask that any pull request should also have respective tests.

@OldMetalmind OldMetalmind self-requested a review August 21, 2019 16:35
Copy link

@isabelcosta isabelcosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I requested changes on some typos I saw in the CONTRIBUTING.md file.

Also, maybe for the future this GitHub feature can be useful to autofill and issue with the issue template provided.

The issue message should explain what the feature is going to change in the app and possible conflicts (“The new endpoints will change the list item in the Home Screen”).

## Issue or Bug
When filing a bug, please follow the [Github Issue Template Guideline](https://gist.github.com/auremoser/72803ba969d0e61ff070#file-issue_template-md)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
When filing a bug, please follow the [Github Issue Template Guideline](https://gist.github.com/auremoser/72803ba969d0e61ff070#file-issue_template-md)
When filling a bug, please follow the [Github Issue Template Guideline](https://gist.github.com/auremoser/72803ba969d0e61ff070#file-issue_template-md)


### Setup

This app is built with Flutter and Dart 2, follwing Bloc's design Pattern.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
This app is built with Flutter and Dart 2, follwing Bloc's design Pattern.
This app is built with Flutter and Dart 2, following Bloc's design Pattern.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants