SDKS-1710 WebAuthn Device Management #415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
witrisna
reviewed
May 16, 2024
| WebAuthnRepository { | ||
|
|
||
| override suspend fun delete(publicKeyCredentialSource: PublicKeyCredentialSource) { | ||
| val credentialId = String(publicKeyCredentialSource.id) |
There was a problem hiding this comment.
Looks like it's not required, the toJson and fromJson methods from the PublicKeyCredentialSource class handles the Base64 decode and decode.
|
|
||
| override suspend fun delete(publicKeyCredentialSource: PublicKeyCredentialSource) { | ||
| val credentialId = String(publicKeyCredentialSource.id) | ||
| val userId = String(publicKeyCredentialSource.userHandle) |
forgerock-auth/src/main/java/org/forgerock/android/auth/RemoteWebAuthnRepository.kt
Outdated
Show resolved
Hide resolved
witrisna
previously approved these changes
May 16, 2024
witrisna
previously approved these changes
May 16, 2024
spetrov
reviewed
May 17, 2024
forgerock-auth/src/main/java/org/forgerock/android/auth/webauthn/FRWebAuthn.kt
Outdated
Show resolved
Hide resolved
forgerock-auth/src/main/java/org/forgerock/android/auth/webauthn/FRWebAuthn.kt
Outdated
Show resolved
Hide resolved
forgerock-auth/src/main/java/org/forgerock/android/auth/webauthn/FRWebAuthn.kt
Outdated
Show resolved
Hide resolved
forgerock-auth/src/main/java/org/forgerock/android/auth/RemoteWebAuthnRepository.kt
Outdated
Show resolved
Hide resolved
forgerock-auth/src/main/java/org/forgerock/android/auth/webauthn/FRWebAuthn.kt
Show resolved
Hide resolved
forgerock-auth/src/main/java/org/forgerock/android/auth/webauthn/WebAuthnRegistration.kt
Outdated
Show resolved
Hide resolved
forgerock-auth/src/test/java/org/forgerock/android/auth/webauthn/FRWebAuthnTest.kt
Outdated
Show resolved
Hide resolved
forgerock-auth/src/main/java/org/forgerock/android/auth/webauthn/FRWebAuthn.kt
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA Ticket
SDKS-1710 WebAuthn Device Management
Description
This change introduces a new method for removing WebAuthn keys from the server and locally in a single call.
Note: The ability to delete keys from the server relies on the availability of a new REST API for WebAuthn resources, which will be available on future versions of PingAM and PingOne Advanced Identity Cloud.