Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDKS-3020] Support Centralize Oidc Signoff with PingOne #421

Merged
merged 1 commit into from
Jun 10, 2024

Conversation

witrisna
Copy link
Contributor

@witrisna witrisna commented Jun 4, 2024

JIRA Ticket

SDKS-3020

Description

Support Centralize Oidc Signoff with PingOne
CleanShot 2024-05-30 at 08 18 28

Copy link

codecov bot commented Jun 4, 2024

Codecov Report

Attention: Patch coverage is 49.24242% with 268 lines in your changes missing coverage. Please review.

Project coverage is 66.12%. Comparing base (f54dad4) to head (3ed82d6).
Report is 2 commits behind head on develop.

Files Patch % Lines
...gerock/android/auth/centralize/AppAuthFragment2.kt 0.00% 64 Missing ⚠️
...in/java/org/forgerock/android/auth/OAuth2Client.kt 76.38% 49 Missing and 2 partials ⚠️
...erock/android/auth/centralize/AuthorizeContract.kt 0.00% 39 Missing ⚠️
...va/org/forgerock/android/auth/AppAuthConfigurer.kt 0.00% 27 Missing ⚠️
...rock/android/auth/centralize/EndSessionContract.kt 0.00% 21 Missing ⚠️
.../org/forgerock/android/auth/centralize/Launcher.kt 0.00% 18 Missing ⚠️
...ain/java/org/forgerock/android/auth/AccessToken.kt 83.87% 8 Missing and 7 partials ⚠️
...rgerock/android/auth/centralize/BrowserLauncher.kt 0.00% 15 Missing ⚠️
...ava/org/forgerock/android/auth/SessionManager.java 36.36% 6 Missing and 1 partial ⚠️
...c/main/java/org/forgerock/android/auth/FRUser.java 0.00% 3 Missing ⚠️
... and 6 more
Additional details and impacted files
@@              Coverage Diff              @@
##             develop     #421      +/-   ##
=============================================
- Coverage      67.92%   66.12%   -1.80%     
+ Complexity      1664     1621      -43     
=============================================
  Files            243      245       +2     
  Lines           7659     7716      +57     
  Branches         823      836      +13     
=============================================
- Hits            5202     5102     -100     
- Misses          2078     2248     +170     
+ Partials         379      366      -13     
Flag Coverage Δ
unit-tests 66.12% <49.24%> (-1.80%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rodrigoareis rodrigoareis self-requested a review June 5, 2024 19:46
CHANGELOG.md Outdated Show resolved Hide resolved
@witrisna witrisna force-pushed the SDKS-3020 branch 2 times, most recently from 97c7275 to fcafce5 Compare June 5, 2024 20:10
Copy link
Contributor

@rodrigoareis rodrigoareis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After quick scan, I found some minor items to be addressed

spetrov
spetrov previously approved these changes Jun 6, 2024
Copy link
Contributor

@spetrov spetrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍🏻

@witrisna witrisna requested a review from rodrigoareis June 10, 2024 16:07
Copy link
Contributor

@rodrigoareis rodrigoareis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@witrisna witrisna merged commit 2efffe8 into develop Jun 10, 2024
9 of 11 checks passed
@spetrov spetrov deleted the SDKS-3020 branch June 11, 2024 17:05
jeyanthanperiyasamy pushed a commit that referenced this pull request Jun 11, 2024
[SDKS-3020] Support Centralize Oidc Signoff with PingOne
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants