-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SDKS-3020] Support Centralize Oidc Signoff with PingOne #421
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #421 +/- ##
=============================================
- Coverage 67.92% 66.12% -1.80%
+ Complexity 1664 1621 -43
=============================================
Files 243 245 +2
Lines 7659 7716 +57
Branches 823 836 +13
=============================================
- Hits 5202 5102 -100
- Misses 2078 2248 +170
+ Partials 379 366 -13
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
forgerock-auth/src/main/java/org/forgerock/android/auth/Config.java
Outdated
Show resolved
Hide resolved
forgerock-auth/src/main/java/org/forgerock/android/auth/Token.kt
Outdated
Show resolved
Hide resolved
97c7275
to
fcafce5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After quick scan, I found some minor items to be addressed
samples/kotlin/src/main/java/com/forgerock/kotlinapp/FRSessionActivity.kt
Show resolved
Hide resolved
samples/kotlin/src/main/java/com/forgerock/kotlinapp/FRSessionActivity.kt
Outdated
Show resolved
Hide resolved
samples/kotlin/src/main/java/com/forgerock/kotlinapp/MainActivity.kt
Outdated
Show resolved
Hide resolved
forgerock-auth/src/main/java/org/forgerock/android/auth/AccessToken.kt
Outdated
Show resolved
Hide resolved
forgerock-auth/src/main/java/org/forgerock/android/auth/OAuth2Client.kt
Outdated
Show resolved
Hide resolved
forgerock-auth/src/main/java/org/forgerock/android/auth/OAuth2Client.kt
Outdated
Show resolved
Hide resolved
forgerock-auth/src/main/java/org/forgerock/android/auth/OAuth2Client.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 👍🏻
forgerock-auth/src/main/java/org/forgerock/android/auth/Result.kt
Outdated
Show resolved
Hide resolved
forgerock-auth/src/main/java/org/forgerock/android/auth/SessionManager.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
[SDKS-3020] Support Centralize Oidc Signoff with PingOne
JIRA Ticket
SDKS-3020
Description
Support Centralize Oidc Signoff with PingOne