Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDKS-3284 Inconsistent behavior when forgerock_url is not provided. #428

Merged
merged 1 commit into from
Jun 19, 2024

Conversation

witrisna
Copy link
Contributor

JIRA Ticket

SDKS-3284

Description

  • Validate the server url before persist, for now, it does not validate the format, just make sure it is not empty.
  • Ignore exception when failed to load the stored configuration.

Copy link

codecov bot commented Jun 19, 2024

Codecov Report

Attention: Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.

Project coverage is 66.32%. Comparing base (705bff0) to head (ab96dcd).

Current head ab96dcd differs from pull request most recent head 2dca085

Please upload reports for the commit 2dca085 to get more accurate results.

Files Patch % Lines
...c/main/java/org/forgerock/android/auth/FRAuth.java 66.66% 2 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop     #428      +/-   ##
=============================================
- Coverage      66.33%   66.32%   -0.01%     
- Complexity      1630     1631       +1     
=============================================
  Files            245      245              
  Lines           7782     7786       +4     
  Branches         855      855              
=============================================
+ Hits            5162     5164       +2     
- Misses          2239     2241       +2     
  Partials         381      381              
Flag Coverage Δ
unit-tests 66.32% <71.42%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

rodrigoareis
rodrigoareis previously approved these changes Jun 19, 2024
Copy link
Contributor

@rodrigoareis rodrigoareis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good to me

- Validate the server url before persist, for now, it does not validate the format, just make sure it is not empty.
- Ignore exception when failed to load the stored configuration.
Copy link
Contributor

@spetrov spetrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@spetrov spetrov merged commit 62b8ea0 into develop Jun 19, 2024
7 of 9 checks passed
@spetrov spetrov deleted the SDKS-3284 branch June 19, 2024 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants