SDKS-3227_Skipping type 4 TextOutputCallbacks #434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, skipping 4 Updated the sample apps to handle the ScriptedTextOutputCallbacks and long content better
george-bafaloukas-forgerock
requested review from
spetrov,
jeyanthanperiyasamy and
witrisna
witrisna
requested changes
Jul 22, 2024
| @@ -59,7 +62,16 @@ JSONObject toJsonObject() throws JSONException { | |||
| } | |||
| JSONArray array = new JSONArray(); | |||
| for (Callback cb : callbacks) { | |||
| array.put(new JSONObject(cb.getContent())); | |||
| if ((cb instanceof TextOutputCallback)) { | |||
There was a problem hiding this comment.
I would handle it on receiving the Callback,
org.forgerock.android.auth.callback.TextOutputCallback#setAttribute
Removing the content when msg type is 4
There was a problem hiding this comment.
Receiving the callback is no problem for the SDK or the server side. Submitting back is what causes issues. I am of the opinion that if we keep the callback and just remove it before submitting, we are more open to anyone using this to pass data (valuable ones not a JS script) back to the SDK. So instead of dropping the support, we just make that an non-submittable callback. Let's discuss this when you come online.
witrisna
previously approved these changes
Jul 24, 2024
spetrov
force-pushed
the
SDKS-3227_TextOutputCallbacks-Type4
branch
from
fecd5dd to
68211c7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added conditional sbmittion of TextOutput Callbacks based on the type skipping 4
Updated the sample apps to handle the ScriptedTextOutputCallbacks and long content better
JIRA Ticket
Please link jira ticket here
Description
Added conditional sbmittion of TextOutput Callbacks based on the type skipping 4
Updated the sample apps to handle the ScriptedTextOutputCallbacks and long content better