Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDKS-3420 Hide Environment information from Sample App #446

Merged
merged 1 commit into from
Sep 17, 2024
Merged

Conversation

witrisna
Copy link
Contributor

JIRA Ticket

SDKS-3420

Description

Hide Environment information from Sample App

@witrisna witrisna requested a review from spetrov September 11, 2024 21:12
Copy link

codecov bot commented Sep 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.28%. Comparing base (566c020) to head (66267d2).
Report is 6 commits behind head on develop.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop     #446   +/-   ##
==========================================
  Coverage      65.28%   65.28%           
  Complexity      1651     1651           
==========================================
  Files            255      255           
  Lines           8009     8009           
  Branches         886      886           
==========================================
  Hits            5229     5229           
  Misses          2381     2381           
  Partials         399      399           
Flag Coverage Δ
unit-tests 65.28% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@rodrigoareis rodrigoareis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good to me

Copy link
Contributor

@spetrov spetrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@spetrov spetrov merged commit d5adc45 into develop Sep 17, 2024
10 of 11 checks passed
@spetrov spetrov deleted the SDKS-3420-2 branch September 17, 2024 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants