Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDKS-3373 - ReCaptcha e2e test cases #452

Merged
merged 1 commit into from
Oct 1, 2024
Merged

SDKS-3373 - ReCaptcha e2e test cases #452

merged 1 commit into from
Oct 1, 2024

Conversation

spetrov
Copy link
Contributor

@spetrov spetrov commented Sep 23, 2024

JIRA Ticket

SDKS-3373 [QA] Test end-to-end flow of ReCaptcha Enterprise

Description

  • Added e2e test cases for the ReCaptcha Enterprise feature. These test cases test both server and client side. These require live server and the following authentication tree:
image

Copy link

codecov bot commented Sep 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.34%. Comparing base (56d157e) to head (522a5d9).
Report is 6 commits behind head on develop.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop     #452      +/-   ##
=============================================
- Coverage      65.36%   65.34%   -0.03%     
+ Complexity      1656     1655       -1     
=============================================
  Files            255      255              
  Lines           8010     8013       +3     
  Branches         888      888              
=============================================
  Hits            5236     5236              
- Misses          2376     2377       +1     
- Partials         398      400       +2     
Flag Coverage Δ
unit-tests 65.34% <100.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@spetrov spetrov force-pushed the SDKS-3373 branch 4 times, most recently from 2ad0d30 to 9bf8b09 Compare September 25, 2024 19:36
@spetrov spetrov changed the title SDKS-3372 - ReCaptcha e2e test cases SDKS-3373 - ReCaptcha e2e test cases Sep 25, 2024
@@ -43,11 +43,17 @@ dependencies {
androidTestImplementation(libs.androidx.biometric.ktx)
androidTestImplementation(libs.nimbus.jose.jwt)
androidTestImplementation(libs.okhttp)
androidTestImplementation(libs.kotlinx.coroutines.test)
testImplementation(libs.kotlinx.coroutines.test)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need this testImplementation(libs.kotlinx.coroutines.test) ?,what if you remove this and run the test

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, looks like this is not needed indeed - I removed it.

@spetrov spetrov merged commit 0dec587 into develop Oct 1, 2024
9 of 11 checks passed
@spetrov spetrov deleted the SDKS-3373 branch October 1, 2024 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants