Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDKS-3423 Handle Sign out with ID Token for PingOne Platform. #462

Merged
merged 1 commit into from
Nov 18, 2024

Conversation

witrisna
Copy link
Contributor

@witrisna witrisna commented Nov 6, 2024

JIRA Ticket

SDKS-3423

Description

Handle Sign out with ID Token for PingOne Platform.

PingOne Platform Client Configuration:

Enable Terminate User Session By ID Token
CleanShot 2024-11-06 at 12 35 54@2x

Make sure do not use oauthSignOutRedirectUri

    val pingOidc = FROptionsBuilder.build {
        server {
            url = "https://auth.pingone.ca/02fb4743-189a-4bc7-9d6c-a919edfe6447/as"
        }
        oauth {
            oauthClientId = "c12743f9-08e8-4420-a624-71bbb08e9fe1"
            oauthRedirectUri = "org.forgerock.demo://oauth2redirect"
            oauthScope = "openid email address phone profile revoke"
            //oauthSignOutRedirectUri = "org.forgerock.demo://oauth2redirect"
        }
    }

When oauthSignOutRedirectUri is configured, the SDK will use browser to handle the logout.

@witrisna witrisna requested review from spetrov and jeyanthanperiyasamy and removed request for spetrov November 6, 2024 20:48
@witrisna witrisna self-assigned this Nov 6, 2024
Copy link

codecov bot commented Nov 6, 2024

Codecov Report

Attention: Patch coverage is 40.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 65.04%. Comparing base (1ad6a27) to head (a57b166).
Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
.../main/java/org/forgerock/android/auth/FROptions.kt 50.00% 0 Missing and 2 partials ⚠️
...in/java/org/forgerock/android/auth/OAuth2Client.kt 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             develop     #462   +/-   ##
==========================================
  Coverage      65.03%   65.04%           
- Complexity      1670     1672    +2     
==========================================
  Files            257      257           
  Lines           8569     8573    +4     
  Branches         904      906    +2     
==========================================
+ Hits            5573     5576    +3     
- Misses          2584     2586    +2     
+ Partials         412      411    -1     
Flag Coverage Δ
unit-tests 65.04% <40.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link
Contributor

@jeyanthanperiyasamy jeyanthanperiyasamy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Copy link
Contributor

@rodrigoareis rodrigoareis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good to me

Copy link
Contributor

@spetrov spetrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 👍🏻

@spetrov spetrov merged commit 0cb37c3 into develop Nov 18, 2024
9 of 11 checks passed
@spetrov spetrov deleted the SDKS-3423 branch November 18, 2024 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants