Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDKS-3697 Prevent duplicated notification on the SDK #465

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

rodrigoareis
Copy link
Contributor

JIRA Ticket

SDKS-3697 Prevent duplicated notification on the SDK

Description

The Android SDK does not verify whether a push notification with an identical message identifier has already been stored, delegating this responsibility to the application developer. This PR include the following changes:

  • Added a new getNotificationByMessageId method to the StorageClient and FRAClient
  • Updated the logic to check whether a payload was already persisted
  • Update unit tests

Copy link

codecov bot commented Jan 3, 2025

Codecov Report

Attention: Patch coverage is 66.66667% with 4 lines in your changes missing coverage. Please review.

Project coverage is 64.47%. Comparing base (9e3be1e) to head (d4b7b38).
Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
...g/forgerock/android/auth/DefaultStorageClient.java 33.33% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             develop     #465   +/-   ##
==========================================
  Coverage      64.47%   64.47%           
- Complexity      1668     1670    +2     
==========================================
  Files            256      256           
  Lines           8641     8653   +12     
  Branches         918      921    +3     
==========================================
+ Hits            5571     5579    +8     
  Misses          2662     2662           
- Partials         408      412    +4     
Flag Coverage Δ
unit-tests 64.47% <66.66%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@spetrov spetrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍🏻

@rodrigoareis rodrigoareis merged commit 9afe9d5 into develop Jan 15, 2025
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants