Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CI #91

Merged
merged 6 commits into from
Sep 4, 2024
Merged

Update CI #91

merged 6 commits into from
Sep 4, 2024

Conversation

slager
Copy link
Contributor

@slager slager commented Aug 12, 2024

This updates the VISCfunctions CI to follow the working VISCtemplates CI, addressing #90.

The runners with old R succeed, and the runners with new R fail, which is as expected because the latter are catching the test errors identified in #89.

I also had to move one latex line from the vignette header to the body to get it to build.

@slager slager requested review from kelliemac and mayerbry August 12, 2024 06:06
@slager slager marked this pull request as ready for review August 12, 2024 06:06
@slager slager self-assigned this Aug 12, 2024
@kelliemac
Copy link
Contributor

kelliemac commented Aug 12, 2024

This looks good to me but I am not super familiar with the details of VISCfunctions so I think I should let @mayerbry be the final approver!

@slager
Copy link
Contributor Author

slager commented Aug 15, 2024

Added a codecov GHA workflow as well, since one was in the old GHA workflow.

Not sure why the test-coverage workflow is not working right now. Any ideas @kelliemac? My best guess is that either there's a syntax error in the workflow somewhere, or that it won't work till it is merged to main.

@kelliemac
Copy link
Contributor

kelliemac commented Aug 23, 2024

@slager I would bet that it doesn't work until it's merged to main. I ran into a similar issue when I created a new github workflow before for VISCtemplates. I wouldn't let this hold up mergning.

@slager slager merged commit 5a2752e into develop Sep 4, 2024
2 of 6 checks passed
@slager slager deleted the ci branch September 4, 2024 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants