-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update CI #91
Conversation
This looks good to me but I am not super familiar with the details of VISCfunctions so I think I should let @mayerbry be the final approver! |
Added a codecov GHA workflow as well, since one was in the old GHA workflow. Not sure why the test-coverage workflow is not working right now. Any ideas @kelliemac? My best guess is that either there's a syntax error in the workflow somewhere, or that it won't work till it is merged to main. |
@slager I would bet that it doesn't work until it's merged to main. I ran into a similar issue when I created a new github workflow before for VISCtemplates. I wouldn't let this hold up mergning. |
This updates the VISCfunctions CI to follow the working VISCtemplates CI, addressing #90.
The runners with old R succeed, and the runners with new R fail, which is as expected because the latter are catching the test errors identified in #89.
I also had to move one latex line from the vignette header to the body to get it to build.