Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding median_first_quart_third_quart to pairwise_test_cont() #99

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

lemireg
Copy link

@lemireg lemireg commented Dec 31, 2024

A number of requests have come in for the testing comparison tables to include Median (25%, 75%) quartiles instead of the current output Median (Min, Max) as a part of the output of pairwise_test_cont() function.

I've started to draft the code to add this functionality (the name is too long! feel free to suggest another). Would be great to go over it with one of you or to get feedback. Thanks!

@lemireg lemireg requested review from slager and mayerbry December 31, 2024 22:07
@lemireg
Copy link
Author

lemireg commented Jan 7, 2025

Bryan's comments:

  • you could get away with Group1_q1 instead of Group1_first_quart (and using q1 or q3 elsewhere)
  • you should check in on the type argument for quantile() function and double-check what the standard is for SAS and hvtn. this is something we've run into in the past when trying to sync results. might be ok to keep the default.
  • you might also force names = FALSE
  • makes sure to update the tests too!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant