-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setting up testthat in analysis repos, and spell check as an example #258
base: develop
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #258 +/- ##
===========================================
+ Coverage 82.10% 82.40% +0.29%
===========================================
Files 8 8
Lines 352 358 +6
===========================================
+ Hits 289 295 +6
Misses 63 63 ☔ View full report in Codecov by Sentry. |
@mayerbry and @lemireg I would love to have your thoughts on this! @slager and @asatofh too, if you have time. I'm hoping that (semi)-automating spell check like this for every VISC repo would save SRAs and others a good bit of time. But beyond spell check, this is also a prototype of other kinds of QC checks we could work on automating. I did this whole thing in half a day with the help of CoPilot, and it should be easier to create future tests like this now that we have one functioning. Let me know if you have any thoughts related to spell checking in particular, or whatever the most annoying report QC checks are that you often find yourself "wasting" time on - we could add those to the queue next. |
I used this way of spell checking in DataPackageR. I found it a little bit cumbersome to maintain the dictionary but if it helps improve spelling in reports, it seems worth doing! I'd probably recommend users do |
Description
This PR adds VISC-specific spell check for analysis repos as a
testthat
function, so that every Rmd file in an analysis repo can be spell-checked at once using, for example,devtools:::check()
. This is helpful for long reports, and serves as a prototype for automating other report QC checks so that we can free up time for less tedious work and more fun!GitHub CoPilot helped me out with this one - I used it to draft the unit test which made this a lot painful to implement.
Related Issues
Related to #181
Checklist
devtools::document