-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Caching with identical inputs #49
Comments
@seankross @sckott -- I'm trying to think through how we would test caching functionality in the existing GitHub Action infrastructure and I think our best option might just be to add a second test run of the exact same workflows (or just a subset of them) and make sure caching is executed correctly. Does that sound right to you? i.e. this doesn't require any new workflows, just a second execution of the existing ones. |
@tefirman found this link looks like GitHub actions may support call caching?? https://graphite.dev/guides/github-actions-caching#understanding-github-actions-caching |
So I understand, caching here refers to Cromwell call caching, not GitHub Actions caching, correct? I think it would work to have an additional job in each of |
I will let Taylor give you more detailed information. but i guess if i understand correctly is that we want to test the cromwell call caching functionality (your link is correct). I guess the question is when we use cromwell via github actions are we able to use wdl unit tests designed to test cromwell call caching feature? Looks like however cromwell is running via github actions this should be possible??? |
Good question, we'd have to look into answering this question more deeply. @tefirman do you think testing caching is in scope for this sprint, considering what we discussed in today's DSSR? |
Definitely just referring to Cromwell call caching for now, Scott's link is correct. It's a pretty big functionality for bioinformatics purposes, so I would like to include it, but in a VERY basic functionality, i.e. calling helloWorld twice and make sure the second time calls from the cache. Mind if I explore this a bit in a separate branch? |
If Cromwell reuses cached results when inputs are unchanged
The text was updated successfully, but these errors were encountered: