Adding cache test WDL and GitHub Action #66
Conversation
|
Added @sitapriyamoorthi for review of the Cromwell/WDL aspects. If we feel like this shouldn't be its own GitHub Action, we can definitely explore other options, just let me know. |
tefirman
added
unit test
|
|
||
| - name: Download Cromwell | ||
| run: | | ||
| wget https://github.com/broadinstitute/cromwell/releases/download/86/cromwell-86.jar |
There was a problem hiding this comment.
use cromwell-87 here and in other places in this file - per discussion in slack about using the same version proof is using
| fi | ||
|
|
||
| # Verify second run was significantly faster | ||
| if [ ${{ steps.second-run.outputs.second_duration }} -gt $(( ${{ steps.first-run.outputs.first_duration }} / 2 )) ]; then |
There was a problem hiding this comment.
In your experience thus far is the timing variable? That is, is this math safe enough that even with variable load on the clusters that this will succeed? Same comment for next if block
|
|
||
| ## Version | ||
| - WDL 1.0 | ||
| - Cromwell 86 |
| exit 1 | ||
| fi | ||
|
|
||
| echo "Cache validation passed!" |
There was a problem hiding this comment.
should there be an exit 0 here? or does it succeed without that explicitly?
Description
Related Issues
Testing