Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

some new tests, and reconfiguring #51

Merged
merged 16 commits into from
Jan 15, 2025
Merged

some new tests, and reconfiguring #51

merged 16 commits into from
Jan 15, 2025

Conversation

sckott
Copy link
Collaborator

@sckott sckott commented Dec 20, 2024

  • CromwellApi: added new methods for search, validate and abort
  • utils: added new past_date fxn to calculate a datetime in the past (or future)
  • metadata tests: add tests for keys on dicts, treating final states and non-final separately
  • new test files for: abort, validate, failures, search
  • new wdl directories: badFile, parseBatchFile
  • incorporates options.json and inputs.json files when submitting jobs

fix #33
fix #59

- CromwellApi: added new methods for search, validate and abort
- utils: added new past_date fxn to calculate a datetime in the past (or future)
- metadata tests: add tests for keys on dicts, treating final states and non-final separately
- new test files for: abort, validate, failures, search
- new wdl directories: badFile, parseBatchFile
@sckott sckott requested review from seankross and tefirman December 20, 2024 22:44
@sckott
Copy link
Collaborator Author

sckott commented Jan 10, 2025

Note: Cromwell Test Run will be failing until #59 is resolved

@sckott sckott linked an issue Jan 10, 2025 that may be closed by this pull request
11 tasks
@sckott sckott requested review from seankross and tefirman and removed request for seankross and tefirman January 15, 2025 19:19
Copy link
Collaborator

@seankross seankross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you!

@seankross seankross added test-infra infrastructure Infrastructure fix to execute WDL GitHub Actions and removed test-infra labels Jan 15, 2025
@sckott sckott merged commit b0fd5a3 into main Jan 15, 2025
17 checks passed
@sckott sckott deleted the api-tests-adding-more branch January 15, 2025 20:38
@tefirman
Copy link
Collaborator

Fully agree, this looks awesome, thanks @sckott !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure Infrastructure fix to execute WDL GitHub Actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prefixes for bad wdl's for validate, run or both Cromwell API tests to dos
3 participants