Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shiboken: update formula to use py311 #444

Closed
wants to merge 1 commit into from

Conversation

ipatch
Copy link
Collaborator

@ipatch ipatch commented Nov 29, 2023

brew style freecad/freecad/[NAME_OF_FORMULA_FILE] 

output from running above command should output something similiar to the below

1 file inspected, no offenses detected
  • Have you ensured your commit passed audit checks, ie.
brew audit freecad/freecad/[NAME_OF_FORMULA_FILE] --online --new-formula

Not all PRs require passing these checks ie. adding [no ci] in the commit message will prevent the CI from running but PRs that change formula files generally should run through the CI checks that way new bottles are built and uploaded to the repository thus not having to build all formula from source but rather installing from a bottle (significantly faster 🐰 ... 🐢)

For more information about this template file learn more

@ipatch
Copy link
Collaborator Author

ipatch commented Nov 29, 2023

need to resolve the below issue,

chris@Chriss-Mac-mini homebrew-freecad % brew linkage --test freecad/freecad/shiboken2@5.15.11
chris@Chriss-Mac-mini homebrew-freecad % brew linkage --cached --test --strict freecad/freecad/shiboken2@5.15.11
Files with missing rpath:
  /Users/chris/homebrew/Cellar/shiboken2@5.15.11/5.15.11_2/lib/python3.11/site-packages/shiboken2/shiboken2.cpython-311-darwin.so

@ipatch
Copy link
Collaborator Author

ipatch commented Nov 29, 2023

the below error message is possibly a false positive due to the way homebrew test-bot is setup,

==> brew bottle --merge --write --no-commit --no-all-checks ./shiboken2@5.15.11--5.15.11_2.ventura.bottle.json --keep-old
==> FAILED
Full bottle --merge --write --no-commit --no-all-checks ./shiboken2@5.15.11--5.15.11_2.ventura.bottle.json --keep-old output
  ==> freecad/freecad/shiboken2@5.15.11
  Error: `--keep-old` was passed but there are changes in:
  sha256 ventura: old: "73461fb88af969d9a6e6cfc06930c0831d6c336386fea732244e884c0f20ee25", new: "0b750ac8d15ce5199d6d09789e177c5f20b74402f8526df946d1a854ef394ef6"

from the below ci run

https://github.com/FreeCAD/homebrew-freecad/actions/runs/7038172387/job/19154527874?pr=444

@ipatch ipatch added pr-pull and removed pr-pull labels Nov 29, 2023
@ipatch
Copy link
Collaborator Author

ipatch commented Nov 29, 2023

it seems pr-pull may not be able to overwrite existing packages? 😕

Error: Failure while executing; `/usr/local/bin/brew pr-upload --debug` exited with 1.
/usr/bin/env /usr/local/opt/skopeo/bin/skopeo inspect --raw docker://ghcr.io/freecad/freecad/shiboken2/5.15.11:5.15.11_2 --creds=ipatch:******
Error: docker://ghcr.io/freecad/freecad/shiboken2/5.15.11:5.15.11_2 already exists!
Error: Kernel.exit
Warning: Removed Sorbet lines from backtrace!
Rerun with --verbose to see the original backtrace

need to look and see if there is a flag for pr-pull that can/will overwrite an existing package if it exists, or i need to possibly bump the revision. 🤔

@ipatch
Copy link
Collaborator Author

ipatch commented Nov 29, 2023

also,

Warning: Calling `brew pr-pull --no-autosquash` is deprecated! There is no replacement.

@ipatch
Copy link
Collaborator Author

ipatch commented Nov 29, 2023

did not see a flag listed for the pr-pull command that could overwrite the existing package / update the existing package. 🤦‍♂️

@ipatch ipatch added pr-pull and removed pr-pull labels Nov 29, 2023
@github-actions github-actions bot closed this in c20f682 Nov 29, 2023
@ipatch ipatch deleted the shiboken.py311 branch November 29, 2023 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant