-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update RX sequence number after refusing TCP FIN packet. #1195
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @ActoryOu for this PR. I already commented the case on the FreeRTOS forum.
I also agree with this extra check:
+ if( lDistance == 1 )
+ {
pxTCPWindow->rx.ulCurrentSequenceNumber =
pxTCPWindow->rx.ulFINSequenceNumber + 1U;
+ }
}
Hi, I have backported the changes to TCP 3.1.0 for testing, using kernel 10.5.1 and Xilinx Zynq port. All appears to be working as expected. Let me know if there is any other information I can provide. Thanks for the great support!
|
Signed-off-by: Gaurav Aggarwal <aggarg@amazon.com>
Update RX sequence number after refusing TCP FIN packet.
Description
As FreeRTOS Forum TCP Refusing FIN mentioned, the expected RX sequence is not well handled in the stack when refusing FIN. Update the RX sequence number when hitting this scenario.
Test Steps
Refer to this forum post for the test result.
Checklist:
Related Issue
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.