test(OpenTelemetry/Transport): assert content type value

FriendsOfOpenTelemetry · Dec 22, 2024 · 831502a · 831502a
1 parent 98b3adf
commit 831502a
Show file tree

Hide file tree

Showing 5 changed files with 8 additions and 5 deletions.
diff --git a/src/DependencyInjection/OpenTelemetryExtension.php b/src/DependencyInjection/OpenTelemetryExtension.php
@@ -53,7 +53,6 @@ protected function loadInternal(array $mergedConfig, ContainerBuilder $container
      */
     private function loadServiceParams(array $config, ContainerBuilder $container): void
     {
-        // TODO These values are not passed to the OpenTelemetry SDK
         $container->setParameter('open_telemetry.service.namespace', $config['namespace']);
         $container->setParameter('open_telemetry.service.name', $config['name']);
         $container->setParameter('open_telemetry.service.version', $config['version']);

diff --git a/tests/Unit/OpenTelemetry/Transport/GrpcTransportFactoryTest.php b/tests/Unit/OpenTelemetry/Transport/GrpcTransportFactoryTest.php
@@ -30,7 +30,8 @@ public function testCreateTransportFromExporter(
         self::assertSame($shouldSupport, $factory->supports($endpoint, $options));
 
         if ($shouldSupport) {
-            $factory->createTransport($endpoint, $options);
+            $transport = $factory->createTransport($endpoint, $options);
+            self::assertSame('application/x-protobuf', $transport->contentType());
         }
     }
 

diff --git a/tests/Unit/OpenTelemetry/Transport/OtlpHttpTransportFactoryTest.php b/tests/Unit/OpenTelemetry/Transport/OtlpHttpTransportFactoryTest.php
@@ -31,7 +31,8 @@ public function testCreateTransportFromExporter(
         self::assertSame($shouldSupport, $factory->supports($endpoint, $options));
 
         if ($shouldSupport) {
-            $factory->createTransport($endpoint, $options);
+            $transport = $factory->createTransport($endpoint, $options);
+            self::assertSame('application/json', $transport->contentType());
         }
     }
 

diff --git a/tests/Unit/OpenTelemetry/Transport/PsrHttpTransportFactoryTest.php b/tests/Unit/OpenTelemetry/Transport/PsrHttpTransportFactoryTest.php
@@ -31,7 +31,8 @@ public function testCreateTransportFromExporter(
         self::assertSame($shouldSupport, $factory->supports($endpoint, $options));
 
         if ($shouldSupport) {
-            $factory->createTransport($endpoint, $options);
+            $transport = $factory->createTransport($endpoint, $options);
+            self::assertSame('application/json', $transport->contentType());
         }
     }
 

diff --git a/tests/Unit/OpenTelemetry/Transport/StreamTransportFactoryTest.php b/tests/Unit/OpenTelemetry/Transport/StreamTransportFactoryTest.php
@@ -31,7 +31,8 @@ public function testCreateTransportFromExporter(
         self::assertSame($shouldSupport, $factory->supports($endpoint, $options));
 
         if ($shouldSupport) {
-            $factory->createTransport($endpoint, $options);
+            $transport = $factory->createTransport($endpoint, $options);
+            self::assertSame('application/json', $transport->contentType());
         }
     }