fix(TraceableHttpClient): span finishes too early

[Kaspiman]

The client works asynchronously. Due to the finally construction, the span is immediately closed, without reflecting the actual result of the request. TraceableResponse class already finished span correctly.

[Kaspiman]

@gaelreyrol Hello! New issue was resolved! I've made a number of improvements to release the package in a private repository at my company. I'm ready to quickly move them to your repository. Working together we can release a stable release.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.51%. Comparing base (b50c27a) to head (98d0b84).
Report is 1 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff              @@
##               main     #105      +/-   ##
============================================
+ Coverage     88.16%   88.51%   +0.34%     
+ Complexity      635      633       -2     
============================================
  Files           115      115              
  Lines          2620     2612       -8     
============================================
+ Hits           2310     2312       +2     
+ Misses          310      300      -10     

Flag	Coverage Δ
phpunit	88.51% <100.00%> (+0.34%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[gaelreyrol]

Hi @Kaspiman! Good catch, I remember that the assertions in the tests were a bit strange but I didn't have the time to dive into it.

I am not sure why the tests does not cover your changes, are you able to break in the catch to see if the code block is executed in the testException case ?

Thanks again for your work!

[Kaspiman]

The exception catch code will never be executed. The response will always be returned successfully, so I removed that catch. The exception will be handled in the same way in TraceableResponse::endSpan. Look at similar http-client in similar repository https://github.com/worldia/instrumentation-bundle/blob/master/src/Http/TracingHttpClient.php#L72

[gaelreyrol]

The exception catch code will never be executed. The response will always be returned successfully, so I removed that catch. The exception will be handled in the same way in TraceableResponse::endSpan. Look at similar http-client in similar repository https://github.com/worldia/instrumentation-bundle/blob/master/src/Http/TracingHttpClient.php#L72

Indeed, it's been a while since I worked on this project, I need catch up.