Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(DependencyInjection): pass configured resource info to providers #106

Merged
merged 1 commit into from
Dec 22, 2024

Conversation

gaelreyrol
Copy link
Contributor

@gaelreyrol gaelreyrol commented Dec 22, 2024

This PR adds a ResourceInfoFactory based on OpenTelemetry ResourceInfoFactory. A custom resource info is now injected to providers so it configure the open_telemetry.service parameters.

Closes #104.

@gaelreyrol gaelreyrol self-assigned this Dec 22, 2024
@gaelreyrol gaelreyrol requested a review from a team as a code owner December 22, 2024 13:49
Copy link

codecov bot commented Dec 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.16%. Comparing base (1fb891a) to head (27e2f03).
Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #106      +/-   ##
============================================
+ Coverage     88.08%   88.16%   +0.08%     
- Complexity      634      635       +1     
============================================
  Files           114      115       +1     
  Lines          2601     2620      +19     
============================================
+ Hits           2291     2310      +19     
  Misses          310      310              
Flag Coverage Δ
phpunit 88.16% <100.00%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coveralls
Copy link

Coverage Status

coverage: 88.382% (+0.09%) from 88.29%
when pulling 27e2f03 on fix/resource-info-from-service-parameters
into 1fb891a on main.

@gaelreyrol gaelreyrol merged commit b50c27a into main Dec 22, 2024
11 checks passed
@gaelreyrol gaelreyrol deleted the fix/resource-info-from-service-parameters branch December 22, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OpenTelemetry service parameters not passed to SDK
2 participants