Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TraceableRouteLoader: fix type error #91

Merged
merged 1 commit into from
Dec 22, 2024

Conversation

Kaspiman
Copy link
Contributor

Error when bin/console c:c:

In TraceableRouteLoader.php line 69:
                                                                                               
  Attempted to call an undefined method named "getDeclaringClass" of class "ReflectionClass". 

@Kaspiman Kaspiman requested a review from a team as a code owner November 11, 2024 17:59
@Kaspiman
Copy link
Contributor Author

@gaelreyrol Hello! Please, review.

Copy link

codecov bot commented Nov 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.08%. Comparing base (8211d43) to head (a1a04c1).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main      #91   +/-   ##
=========================================
  Coverage     88.07%   88.08%           
- Complexity      633      634    +1     
=========================================
  Files           114      114           
  Lines          2599     2601    +2     
=========================================
+ Hits           2289     2291    +2     
  Misses          310      310           
Flag Coverage Δ
phpunit 88.08% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gaelreyrol
Copy link
Contributor

Hi @Kaspiman,

Thanks for reporting this, I will review this as soon as I have time to do so, in the mean time can you please solve CI errors?

@Kaspiman
Copy link
Contributor Author

@gaelreyrol Sure!

@Kaspiman
Copy link
Contributor Author

@gaelreyrol Hello, how to fix Fossa Scan check? https://github.com/FriendsOfOpenTelemetry/opentelemetry-bundle/actions/runs/11796593160/job/32860468020?pr=91

Error: Input required and not supplied: api-key

@gaelreyrol
Copy link
Contributor

gaelreyrol commented Nov 26, 2024

@gaelreyrol Hello, how to fix Fossa Scan check? https://github.com/FriendsOfOpenTelemetry/opentelemetry-bundle/actions/runs/11796593160/job/32860468020?pr=91

Error: Input required and not supplied: api-key

Hi @Kaspiman, don't bother with the "Fossa Scan & Test" checks, it's because the workflow is ran from a fork, I need to disable them in those case.

@Kaspiman
Copy link
Contributor Author

So, my code is ready to merge! Also i created #92

@gaelreyrol
Copy link
Contributor

Hi @Kaspiman, could you explain how did you encountered this error? I am trying to setup a reproducer so I can cover it with a test case.

@gaelreyrol
Copy link
Contributor

Hi @Kaspiman, could you explain how did you encountered this error? I am trying to setup a reproducer so I can cover it with a test case.

I've managed to reproduce the error you reported, I updated your PR to simplify the fix and keep the structure I used.
Thanks again for your work!

gaelreyrol
gaelreyrol previously approved these changes Dec 22, 2024
@gaelreyrol gaelreyrol merged commit 0afa9b3 into FriendsOfOpenTelemetry:main Dec 22, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants