-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TraceableRouteLoader: fix type error #91
TraceableRouteLoader: fix type error #91
Conversation
@gaelreyrol Hello! Please, review. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #91 +/- ##
=========================================
Coverage 88.07% 88.08%
- Complexity 633 634 +1
=========================================
Files 114 114
Lines 2599 2601 +2
=========================================
+ Hits 2289 2291 +2
Misses 310 310
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Hi @Kaspiman, Thanks for reporting this, I will review this as soon as I have time to do so, in the mean time can you please solve CI errors? |
@gaelreyrol Sure! |
@gaelreyrol Hello, how to fix Fossa Scan check? https://github.com/FriendsOfOpenTelemetry/opentelemetry-bundle/actions/runs/11796593160/job/32860468020?pr=91
|
Hi @Kaspiman, don't bother with the "Fossa Scan & Test" checks, it's because the workflow is ran from a fork, I need to disable them in those case. |
So, my code is ready to merge! Also i created #92 |
Hi @Kaspiman, could you explain how did you encountered this error? I am trying to setup a reproducer so I can cover it with a test case. |
a6c72d7
to
f775956
Compare
I've managed to reproduce the error you reported, I updated your PR to simplify the fix and keep the structure I used. |
…tDeclaringClass" of class "ReflectionClass"
f775956
to
a1a04c1
Compare
Error when
bin/console c:c: