Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The height_expiration_txs can growth infinitely in TxPool #2564

Open
xgreenx opened this issue Jan 15, 2025 · 3 comments
Open

The height_expiration_txs can growth infinitely in TxPool #2564

xgreenx opened this issue Jan 15, 2025 · 3 comments
Assignees
@AurelienFT
Labels
bug Something isn't working

Comments

@xgreenx
Copy link
Collaborator

xgreenx commented Jan 15, 2025

The #2447 added the height_expiration_txs field to the TxPool service. If someone submits a lot of transactions with expiration in the future(like in one year), this information will live forever in the TxPool, potentially consuming a lot of memory.
@xgreenx xgreenx added the bug Something isn't working label Jan 15, 2025
@AurelienFT
Copy link
Contributor

Same problem exists with time_txs_submitted

@xgreenx
Copy link
Collaborator Author

xgreenx commented Jan 15, 2025

It doesn't exist with time_txs_submitted since the value in are Time::now(), and will be removed after TTL is passed - so after 5 minutes=)

@AurelienFT
Copy link
Contributor

Right :)

@AurelienFT AurelienFT mentioned this issue Jan 16, 2025
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AurelienFT AurelienFT

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@xgreenx @AurelienFT