Update height_expiration_txs to not grow indefinitely
#2579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AurelienFT
requested review from
xgreenx,
Dentosal and
MitchTurner
as code owners
rafal-ch
reviewed
Jan 16, 2025
rafal-ch
reviewed
Jan 16, 2025
rafal-ch
reviewed
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked Issues/PRs
#2564
Description
At a cost of some performance, because we now iterate over an
HashSetinstead of aVec, we remove transactions fromheight_expiration_txswhen we prune them and when they are inserted on a block which is the two cases where a transaction can be removed. Maybe we should be clearer on the code where the tx are removed and regroup the behaviour in the same place (#2580)Checklist
Before requesting review