Generate rubocop_todo and autocorrect the specs

The main part of the project will be fixed in a separate PR.

.rubocop.yml

@@ -1,4 +1,8 @@
+inherit_from: .rubocop_todo.yml
+
 AllCops:
+  TargetRubyVersion: 2.7
+  NewCops: enable
   Exclude:
     - '*.gemspec'
     - 'gemfiles/*'

.rubocop_todo.yml

@@ -0,0 +1,206 @@
+# This configuration was generated by
+# `rubocop --auto-gen-config --exclude-limit 10000000`
+# on 2024-02-09 15:03:07 UTC using RuboCop version 1.60.2.
+# The point is for the user to remove these configuration records
+# one by one as the offenses are removed from the code base.
+# Note that changes in the inspected code, or installation of new
+# versions of RuboCop, may require this file to be generated again.
+
+# Offense count: 5
+# This cop supports safe autocorrection (--autocorrect).
+# Configuration parameters: TreatCommentsAsGroupSeparators, ConsiderPunctuation, Include.
+# Include: **/*.gemfile, **/Gemfile, **/gems.rb
+Bundler/OrderedGems:
+  Exclude:
+    - 'Gemfile'
+
+# Offense count: 1
+# This cop supports safe autocorrection (--autocorrect).
+Layout/EmptyLineAfterGuardClause:
+  Exclude:
+    - 'lib/loga/formatters/gelf_formatter.rb'
+
+# Offense count: 34
+# This cop supports safe autocorrection (--autocorrect).
+# Configuration parameters: AllowMultipleStyles, EnforcedHashRocketStyle, EnforcedColonStyle, EnforcedLastArgumentHashStyle.
+# SupportedHashRocketStyles: key, separator, table
+# SupportedColonStyles: key, separator, table
+# SupportedLastArgumentHashStyles: always_inspect, always_ignore, ignore_implicit, ignore_explicit
+Layout/HashAlignment:
+  Exclude:
+    - 'lib/loga/configuration.rb'
+    - 'lib/loga/formatters/gelf_formatter.rb'
+    - 'lib/loga/rack/logger.rb'
+    - 'lib/loga/railtie.rb'
+    - 'lib/loga/sidekiq6/job_logger.rb'
+
+# Offense count: 1
+# This cop supports safe autocorrection (--autocorrect).
+# Configuration parameters: AllowDoxygenCommentStyle, AllowGemfileRubyComment.
+Layout/LeadingCommentSpace:
+  Exclude:
+    - 'lib/loga/railtie.rb'
+
+# Offense count: 2
+# Configuration parameters: AllowComments, AllowEmptyLambdas.
+Lint/EmptyBlock:
+  Exclude:
+    - 'Appraisals'
+    - 'spec/integration/sinatra_spec.rb'
+
+# Offense count: 1
+# Configuration parameters: AllowedParentClasses.
+Lint/MissingSuper:
+  Exclude:
+    - 'lib/loga/formatters/gelf_formatter.rb'
+
+# Offense count: 1
+# This cop supports safe autocorrection (--autocorrect).
+Lint/RedundantCopDisableDirective:
+  Exclude:
+    - 'lib/loga/railtie.rb'
+
+# Offense count: 2
+# This cop supports safe autocorrection (--autocorrect).
+Lint/SendWithMixinArgument:
+  Exclude:
+    - 'lib/loga/railtie.rb'
+
+# Offense count: 1
+# Configuration parameters: AllowedMethods, AllowedPatterns.
+Metrics/CyclomaticComplexity:
+  Max: 8
+
+# Offense count: 1
+# Configuration parameters: AllowedMethods, AllowedPatterns.
+Metrics/PerceivedComplexity:
+  Max: 9
+
+# Offense count: 1
+# This cop supports safe autocorrection (--autocorrect).
+Migration/DepartmentName:
+  Exclude:
+    - 'lib/loga/railtie.rb'
+
+# Offense count: 1
+# This cop supports safe autocorrection (--autocorrect).
+# Configuration parameters: PreferredName.
+Naming/RescuedExceptionsVariableName:
+  Exclude:
+    - 'lib/loga/sidekiq5/job_logger.rb'
+
+# Offense count: 3
+# Configuration parameters: Prefixes, AllowedPatterns.
+# Prefixes: when, with, without
+RSpec/ContextWording:
+  Exclude:
+    - 'spec/support/gethostname_shared.rb'
+    - 'spec/support/timecop_shared.rb'
+    - 'spec/unit/loga/configuration_spec.rb'
+
+# Offense count: 41
+# Configuration parameters: AllowSubject.
+RSpec/MultipleMemoizedHelpers:
+  Max: 12
+
+# Offense count: 6
+# Configuration parameters: AllowedPatterns.
+# AllowedPatterns: ^expect_, ^assert_
+RSpec/NoExpectationExample:
+  Exclude:
+    - 'spec/integration/sidekiq60_spec.rb'
+    - 'spec/integration/sidekiq61_spec.rb'
+    - 'spec/integration/sidekiq65_spec.rb'
+    - 'spec/integration/sidekiq7_spec.rb'
+
+# Offense count: 2
+# Configuration parameters: Include, CustomTransform, IgnoreMethods, IgnoreMetadata.
+# Include: **/*_spec.rb
+RSpec/SpecFilePathFormat:
+  Exclude:
+    - '**/spec/routing/**/*'
+    - 'spec/integration/rails/action_mailer_spec.rb'
+    - 'spec/integration/rails/railtie_spec.rb'
+
+# Offense count: 1
+RSpec/SubjectDeclaration:
+  Exclude:
+    - 'spec/unit/loga/event_spec.rb'
+
+# Offense count: 1
+# This cop supports unsafe autocorrection (--autocorrect-all).
+# Configuration parameters: AllowedReceivers.
+Style/CollectionCompact:
+  Exclude:
+    - 'lib/loga/configuration.rb'
+
+# Offense count: 1
+# This cop supports safe autocorrection (--autocorrect).
+# Configuration parameters: Keywords, RequireColon.
+# Keywords: TODO, FIXME, OPTIMIZE, HACK, REVIEW, NOTE
+Style/CommentAnnotation:
+  Exclude:
+    - 'lib/loga/configuration.rb'
+
+# Offense count: 25
+# This cop supports unsafe autocorrection (--autocorrect-all).
+# Configuration parameters: EnforcedStyle.
+# SupportedStyles: always, always_true, never
+Style/FrozenStringLiteralComment:
+  Exclude:
+    - 'Appraisals'
+    - 'Gemfile'
+    - 'Guardfile'
+    - 'Rakefile'
+    - 'lib/loga.rb'
+    - 'lib/loga/configuration.rb'
+    - 'lib/loga/event.rb'
+    - 'lib/loga/ext/core/tempfile.rb'
+    - 'lib/loga/ext/rails/rack/debug_exceptions.rb'
+    - 'lib/loga/ext/rails/rack/logger.rb'
+    - 'lib/loga/ext/rails/rack/logger3.rb'
+    - 'lib/loga/formatters/gelf_formatter.rb'
+    - 'lib/loga/formatters/simple_formatter.rb'
+    - 'lib/loga/log_subscribers/action_mailer.rb'
+    - 'lib/loga/parameter_filter.rb'
+    - 'lib/loga/rack/logger.rb'
+    - 'lib/loga/rack/request.rb'
+    - 'lib/loga/rack/request_id.rb'
+    - 'lib/loga/railtie.rb'
+    - 'lib/loga/service_version_strategies.rb'
+    - 'lib/loga/sidekiq5/job_logger.rb'
+    - 'lib/loga/sidekiq6/job_logger.rb'
+    - 'lib/loga/tagged_logging.rb'
+    - 'lib/loga/utilities.rb'
+    - 'lib/loga/version.rb'
+
+# Offense count: 1
+# This cop supports unsafe autocorrection (--autocorrect-all).
+Style/GlobalStdStream:
+  Exclude:
+    - 'lib/loga/configuration.rb'
+
+# Offense count: 1
+# This cop supports unsafe autocorrection (--autocorrect-all).
+# Configuration parameters: EnforcedStyle.
+# SupportedStyles: literals, strict
+Style/MutableConstant:
+  Exclude:
+    - 'lib/loga/rack/request.rb'
+
+# Offense count: 2
+Style/OpenStructUse:
+  Exclude:
+    - 'spec/unit/loga/formatters/gelf_formatter_spec.rb'
+
+# Offense count: 3
+# This cop supports safe autocorrection (--autocorrect).
+Style/RedundantFileExtensionInRequire:
+  Exclude:
+    - 'lib/loga/railtie.rb'
+
+# Offense count: 1
+# This cop supports safe autocorrection (--autocorrect).
+Style/RedundantFreeze:
+  Exclude:
+    - 'lib/loga/sidekiq7/job_logger.rb'

spec/integration/rails/action_mailer_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 RSpec.describe Loga::LogSubscribers::ActionMailer, if: Rails.env.production? do

spec/integration/rails/railtie_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'ostruct'
 
 RSpec.describe Loga::Railtie do
@@ -38,7 +40,7 @@
       end
 
       it 'disables colorized logging' do
-        expect(app.config.colorize_logging).to eq(false)
+        expect(app.config.colorize_logging).to be(false)
       end
     end
 

spec/integration/rails/request_spec.rb

@@ -1,7 +1,9 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
-RSpec.describe 'Structured logging with Rails', timecop: true,
-                                                if: Rails.env.production? do
+RSpec.describe 'Structured logging with Rails', :timecop,
+               if: Rails.env.production? do
   let(:app) { Rails.application }
 
   let(:log_entries) do

spec/integration/sidekiq5_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 require 'timecop'
 require 'fakeredis'
@@ -24,8 +26,8 @@ def perform(_name); end
       attr_reader :latest_error, :mutex, :cond
 
       def initialize
-        @mutex = ::Mutex.new
-        @cond = ::ConditionVariable.new
+        @mutex = Mutex.new
+        @cond = ConditionVariable.new
       end
 
       def processor_died(_inst, err)
@@ -84,7 +86,7 @@ def read_json_log(line:)
     aggregate_failures do
       expect(last_element['class']).to eq 'MySidekiqWorker'
       expect(last_element['args']).to eq ['Bob']
-      expect(last_element['retry']).to eq true
+      expect(last_element['retry']).to be true
       expect(last_element['queue']).to eq 'default'
     end
   end
@@ -107,16 +109,16 @@ def read_json_log(line:)
 
     aggregate_failures do
       expect(json_line).to include(
-        '_queue'=> 'default',
-        '_retry'=> true,
-        '_params'=> ['Bob'],
-        '_class'=> 'MySidekiqWorker',
-        '_type'=> 'sidekiq',
-        '_service.name'=> 'hello_world_app',
-        '_service.version'=> '1.0',
-        '_tags'=> '',
-        'level'=> 6,
-        'version'=> '1.1',
+        '_queue' => 'default',
+        '_retry' => true,
+        '_params' => ['Bob'],
+        '_class' => 'MySidekiqWorker',
+        '_type' => 'sidekiq',
+        '_service.name' => 'hello_world_app',
+        '_service.version' => '1.0',
+        '_tags' => '',
+        'level' => 6,
+        'version' => '1.1',
       )
 
       %w[_created_at _enqueued_at _jid _duration timestamp host].each do |key|

spec/integration/sidekiq60_spec.rb

@@ -31,8 +31,8 @@ def perform(_name)
       attr_reader :cond
 
       def initialize
-        @mutex = ::Mutex.new
-        @cond = ::ConditionVariable.new
+        @mutex = Mutex.new
+        @cond = ConditionVariable.new
       end
 
       def processor_died(_inst, err)
@@ -103,7 +103,7 @@ def dump_log
     aggregate_failures do
       expect(last_element['class']).to eq 'MySidekiqWorker'
       expect(last_element['args']).to eq ['Bob']
-      expect(last_element['retry']).to eq true
+      expect(last_element['retry']).to be true
       expect(last_element['queue']).to eq 'default'
     end
   end

spec/integration/sidekiq61_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 require 'timecop'
 require 'fakeredis'
@@ -27,8 +29,8 @@ def perform(_name)
       attr_reader :latest_error, :mutex, :cond
 
       def initialize
-        @mutex = ::Mutex.new
-        @cond = ::ConditionVariable.new
+        @mutex = Mutex.new
+        @cond = ConditionVariable.new
       end
 
       def processor_died(_inst, err)
@@ -46,7 +48,7 @@ def options
           concurrency: 3,
           queues: ['default'],
           job_logger: Loga::Sidekiq6::JobLogger,
-        }.tap { |opts| opts[:fetch] = ::Sidekiq::BasicFetch.new(opts) }
+        }.tap { |opts| opts[:fetch] = Sidekiq::BasicFetch.new(opts) }
       end
     end
   end
@@ -87,7 +89,7 @@ def read_json_log(line:)
     aggregate_failures do
       expect(last_element['class']).to eq 'MySidekiqWorker'
       expect(last_element['args']).to eq ['Bob']
-      expect(last_element['retry']).to eq true
+      expect(last_element['retry']).to be true
       expect(last_element['queue']).to eq 'default'
     end
   end

spec/integration/sidekiq65_spec.rb

@@ -75,7 +75,7 @@ def read_json_log(line:)
     aggregate_failures do
       expect(last_element['class']).to eq 'MySidekiqWorker'
       expect(last_element['args']).to eq ['Bob']
-      expect(last_element['retry']).to eq true
+      expect(last_element['retry']).to be true
       expect(last_element['queue']).to eq 'default'
     end
   end