Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

spotless pre-commit 설정 #5

Merged
merged 16 commits into from
Jan 14, 2025
Merged

spotless pre-commit 설정 #5

merged 16 commits into from
Jan 14, 2025

Conversation

cmj7271
Copy link
Collaborator

@cmj7271 cmj7271 commented Jan 8, 2025

✨ 기능

commit 시 자동으로 spotless 가 적용되도록 설정

cmj7271 added 16 commits January 6, 2025 23:49
@cmj7271
jpa, postegresql driver 의존성 추가
754a8c4
@cmj7271
postgresql driver 및 jpa 의존성 추가
a260fdc
@cmj7271
driver 연결 및 server.env db.env 추가
15f780e
@cmj7271
docker compose 에 db 연결
6cdb08d
@cmj7271
pgAdmin 설정
efd8c69 
localhost:8088 에서 접속 가능
@cmj7271
리뷰어 멘션이 가능하도록 고쳤고, PR 제목이 보이도록 수정
616c90c
@cmj7271
sql driver 를 runtimeOnly 에서 implementation 으로 변경
a5f8fd9
@cmj7271
commit 시 자동으로 spotless 적용하도록 설정
9b0c29e
@cmj7271
test
5159dac
@cmj7271
test
60ebd32
@cmj7271
Revert "test"
c522792 
This reverts commit 60ebd32.
@cmj7271
Revert "test"
cba9f7d 
This reverts commit 5159dac.
@cmj7271
pre commit test
93c89d4
@cmj7271
Revert "pre commit test"
cbf4d1c 
This reverts commit 93c89d4.
@cmj7271
pre-commit 작동하도록 task 수정
9197433 
task executableGitHooks 추가
@cmj7271
docker compose 로 실행시 실행 불가인 점 해결
18ce8a0 
problem: .git 을 사용하지 않기 때문에 생긴 문제
sol: compose 에 환경 변수 추가하여 이 변수에 따라 실행 여부 결정
JaehoonJung0430
JaehoonJung0430 previously approved these changes Jan 14, 2025
View reviewed changes
Copy link
Collaborator

@JaehoonJung0430 JaehoonJung0430 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

좋아요..

@cmj7271 cmj7271 dismissed JaehoonJung0430’s stale review January 14, 2025 06:10

The merge-base changed after approval.

JaehoonJung0430
JaehoonJung0430 approved these changes Jan 14, 2025
View reviewed changes
Copy link
Collaborator

@JaehoonJung0430 JaehoonJung0430 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good

JaehoonJung0430
JaehoonJung0430 approved these changes Jan 14, 2025
View reviewed changes
Copy link
Collaborator

@JaehoonJung0430 JaehoonJung0430 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good

@cmj7271 cmj7271 merged commit 7ef84f1 into main Jan 14, 2025
1 check passed
@cmj7271 cmj7271 deleted the feature/pre-commit branch January 14, 2025 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JaehoonJung0430 JaehoonJung0430 JaehoonJung0430 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cmj7271 @JaehoonJung0430