Fix JS regex use to validate IRIS IAM strings

[gregcorbett]

No description provided.

[ghost]

It feels like these should eventually not be hardcoded values.

[ElliottKasoar]

Minor point but should // End with @iris.iam.ac.uk be updated to reflect the correct string?

It's probably obvious, but just to note that the commented out regExIdString above was planned to check the rest of the form of the ID string. It may be worth either implementing it for a more detailed check, or removing it if it's never going to be used (including it would "give away" the full form of the ID string, which may be a issue in itself).

[ghost]

Minor point but should // End with @iris.iam.ac.uk be updated to reflect the correct string?

Seems like a good idea.

[ghost]

It's probably obvious, but just to note that the commented out regExIdString above was planned to check the rest of the form of the ID string. It may be worth either implementing it for a more detailed check, or removing it if it's never going to be used (including it would "give away" the full form of the ID string, which may be a issue in itself).

Why was it not used in the first place, and what would be the implication of the 'give away'?

[ElliottKasoar]

Why was it not used in the first place

From what I can recall, I think it was a combination of seeming unnecessary, and that I couldn't test it fully, as my instance of GOCDB didn't have IRIS IAM auth enabled (so I wasn't even registered myself).

I think the longer form was essentially a placeholder based on discussions with @gregcorbett about the expected full form of the ID string, but later we moved towards more minimal validation that was sufficient to differentiate the different auth types (e.g. // End with @egi.eu and // Start with slash only).

and what would be the implication of the 'give away'?

I meant in the sense of helping people too much in guessing what an ID string should be that they're not in possession of, but I don't think it's really an issue?

[gregcorbett]

Minor point but should // End with @iris.iam.ac.uk be updated to reflect the correct string?

Ah yes, I've changed the code but not the comment 🤦

[ghost]

I meant in the sense of helping people too much in guessing what an ID string should be that they're not in possession of, but I don't think it's really an issue?

No I don't think so. The form is (needs to be) published info. I guess this validation is aimed at trapping typos in a form input field.

[gregcorbett]

Minor point but should // End with @iris.iam.ac.uk be updated to reflect the correct string?

Ah yes, I've changed the code but not the comment 🤦

I've fixed this and rebased (into a single commit) the branch on top of the latest dev.

[gregcorbett]

This has been running on the IRIS instance since at least Jun 2022.

[Sae126V]

LGTM

[gregcorbett]

rebasing on latest dev