Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GT-193] Update css properties for service group #467

Merged
merged 1 commit into from
Nov 29, 2023
Merged

[GT-193] Update css properties for service group #467

merged 1 commit into from
Nov 29, 2023

Conversation

Sae126V
Copy link
Contributor

@Sae126V Sae126V commented Aug 14, 2023

Update CSS properties to support service group names being displayed properly. So that the long sentence(words) can be broken down based on the parent div.

Resolves #374

@Sae126V Sae126V requested a review from a team as a code owner August 14, 2023 11:01
@Sae126V Sae126V marked this pull request as draft August 14, 2023 11:10
@Sae126V Sae126V force-pushed the GT-193-Layout-can-be-wonky-on-ServiceGroup-page branch from c4be1c6 to 3067ab2 Compare August 14, 2023 11:12
@Sae126V Sae126V marked this pull request as ready for review August 14, 2023 11:12
@gregcorbett
Copy link
Member

ah so the desired behaviour here is for the icon and site name to stay where they are, and the description text wrap if it needs to, similar to what happens for Sites with a long description:

image

@Sae126V
Copy link
Contributor Author

Sae126V commented Aug 14, 2023

Updated the code to implement site like functionality, Greg. Done

@Sae126V Sae126V marked this pull request as draft August 15, 2023 07:36
@Sae126V Sae126V force-pushed the GT-193-Layout-can-be-wonky-on-ServiceGroup-page branch from 54d6459 to 4ce7dfb Compare August 15, 2023 08:03
@Sae126V Sae126V marked this pull request as ready for review August 15, 2023 08:03
gregcorbett
gregcorbett reviewed Sep 12, 2023
View reviewed changes
Copy link
Member

@gregcorbett gregcorbett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionally this works 😄, I've left a couple of questions about line splitting and indentation

@gregcorbett
Copy link
Member

LGTM, can you squash the commits into the first one?

@Sae126V Sae126V force-pushed the GT-193-Layout-can-be-wonky-on-ServiceGroup-page branch 5 times, most recently from 21c5d58 to ab59d1f Compare September 15, 2023 09:51
Sae126V added a commit to Sae126V/gocdb that referenced this pull request Sep 20, 2023
@Sae126V
[GT-193] Apply styles to the files in GOCDB#467
dd5fde5
@Sae126V Sae126V mentioned this pull request Sep 20, 2023
Open
Sae126V added a commit to Sae126V/gocdb that referenced this pull request Sep 20, 2023
@Sae126V
[GT-193] Apply styles to the files in (GOCDB#467)
ea4d9ff
gregcorbett
gregcorbett approved these changes Nov 29, 2023
View reviewed changes
Copy link
Member

@gregcorbett gregcorbett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@gregcorbett
Copy link
Member

rebasing on top of latest dev

@gregcorbett gregcorbett force-pushed the GT-193-Layout-can-be-wonky-on-ServiceGroup-page branch from ab59d1f to b54a1f1 Compare November 29, 2023 11:18
@gregcorbett gregcorbett self-assigned this Nov 29, 2023
@gregcorbett gregcorbett added this to the May 2023 milestone Nov 29, 2023
@gregcorbett gregcorbett merged commit c065546 into GOCDB:dev Nov 29, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gregcorbett gregcorbett gregcorbett approved these changes

Assignees

@gregcorbett gregcorbett

Labels
enhancement
Projects
None yet
Milestone
5.11.0
Development

Successfully merging this pull request may close these issues.

Layout can be wonky on ServiceGroup page
2 participants
@Sae126V @gregcorbett