Fix code style issues in sample data deploy scripts #482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do mark this as ready for review once those changes are made 😄 |
rowan04
force-pushed
the
481-code-style-issues-in-sample-data-deploy-scripts
branch
from
fc471ff to
52ba3f2
Compare
|
rebase to squash extra commit into previous commit |
rowan04
force-pushed
the
481-code-style-issues-in-sample-data-deploy-scripts
branch
from
18d04c1 to
c96fccc
Compare
|
update with rebase to latest dev |
gregcorbett
approved these changes
Nov 29, 2023
|
rebasing on current dev |
gregcorbett
force-pushed
the
481-code-style-issues-in-sample-data-deploy-scripts
branch
from
c96fccc to
ae84cac
Compare
…ipts - not doing this produces a codacy/codeclimate fail
- to fix code style issues that get flagged by codacy/codeclimate
- lines over 80 characters flag codeclimate fails - this splits up long lines in the deploy directory
- opening parenthesis at end of line - one argument per line - closing parenthesis on own line - indentation fixes - spaces after closing parenthesis before an opening parenthesis - some issue fixes suggested by codeclimate
gregcorbett
force-pushed
the
481-code-style-issues-in-sample-data-deploy-scripts
branch
from
ae84cac to
f3d39d7
Compare
gregcorbett
deleted the
481-code-style-issues-in-sample-data-deploy-scripts
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #481
Resolves GT-202