Drop PHP 5.X support #494
Merged
Drop PHP 5.X support #494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregcorbett
force-pushed
the
php7.4-upgrade
branch
from
62adc2a to
6a752e5
Compare
gregcorbett
force-pushed
the
php7.4-upgrade
branch
from
6a752e5 to
cd5805b
Compare
gregcorbett
force-pushed
the
php7.4-upgrade
branch
from
cd5805b to
88c34a3
Compare
Fair point, for completeness - it's because 7.4 is the version of PHP 7 readily install-able on Rocky8 (see somewhat obscure reference in e2042aa)
8.X requires a later release of version 2.X of the Doctrine ORM before the tests will even run (279606c) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebase after #509 is merged.This PR removes
composer-5.4.{json, lock}tocomposer.{json.lock}and drops PHP 5.x from the CI tests.