Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ShibToken for Keycloak based EGI Check-in to master #499

Merged
merged 3 commits into from
Nov 30, 2023

Conversation

gregcorbett
Copy link
Member

@gregcorbett gregcorbett commented Nov 23, 2023

This has included:

  • switching to aai-demo.egi.eu for preproduction, on the advice of EGI Check In team
  • updating the expected IdPs from subdomain/proxy/saml2/idp/metadata.php to subdomain/auth/realms/egi
  • moving from using epuid to voPersonID

Related ticket: https://ggus.eu/index.php?mode=ticket_info&ticket_id=164026

Once this is confirmed to work in production, before merging I'll bump the version number up to 5.10.5. This PR deliberately merges into master so that it can be released quckly, in isolation.

- this has included:
  - switching to aai-demo.egi.eu for preproduction, on the
    advice of EGI Check In team
  - updating the expected IdPs from subdomain/proxy/saml2/idp/metadata.php
    to subdomain/auth/realms/egi
  - moving from using epuid to voPersonID

- related ticket: https://ggus.eu/index.php?mode=ticket_info&ticket_id=164026
@gregcorbett gregcorbett self-assigned this Nov 23, 2023
@gregcorbett gregcorbett requested a review from a team as a code owner November 23, 2023 17:09
@gregcorbett gregcorbett changed the title Update ShibToken for Keycloak based EGI Check In to master Update ShibToken for Keycloak based EGI Check-In to master Nov 23, 2023
@gregcorbett gregcorbett changed the title Update ShibToken for Keycloak based EGI Check-In to master Update ShibToken for Keycloak based EGI Check-in to master Nov 24, 2023
Copy link
Contributor

@Sae126V Sae126V left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@gregcorbett gregcorbett merged commit 0a1d9eb into GOCDB:master Nov 30, 2023
11 of 17 checks passed
@gregcorbett gregcorbett deleted the keyclock branch November 30, 2023 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants