Release 5.11.0 to master #506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edit/success screens
Removed unused method for loading reserved scopes from local_config.xml and adjust some comments.
Modified scope handling.
This nested list was missing list tags on the outer list which was making it appear wonky. Inner scope indented.
Add unordered lists tags to fix wonky list
Release 5.10.0 to dev
Allow single quote in user identifiers to dev
Replace tabs for spaces and reindent gocdb_schema.xml
- Fixed Codacy issues - Changed dryRun variable to Boolean for clairty - Added an if statement so outputting to file after no login date only happens on dry run. - Changed a comment - Changed file output to CSV to make it more machine readable
Co-authored-by: Adrian Coveney <4836233+tofu-rocketry@users.noreply.github.com>
Co-authored-by: Adrian Coveney <4836233+tofu-rocketry@users.noreply.github.com>
- Adds an else clause to prevent deleteUser function being called whether it is a dry run or not - Warning emails are no longer sent in dry run mode - Changes the file type of the written to file from .txt to .csv - Various changes to where new lines are added - Inline comments are reworked to not be on the same line as a statement
Added an extra space on lines 67-70 as indent was 7 spaces, not 8
- Removed unnecessary continue statement and coinciding comment - Added new lines for better output readability
381 user removal dry run
Option for page banner on all pages
Page banner standards
Add phpmd to composer
- as old egi wiki links are out of date, references are reworked to point to somewhere appropriate - rewording of text and reformatting of links
- removal of spaces after some hyperlinked words - rewoding of text to read better
Remove references to EGI wiki on Help and Contact page
- removed instances where gocdb-admins@mailman.egi.eu was hardwired into code - replaced the email addresses with a config call - split email adresses into 'to' and 'from' addresses - added lines in config file for to and from email adresses - added reply-to adresses in email text when emails are sent
Fix PHP 7.4 MariaDB test, Drop experimental MariaDB tests
…rviceGroup-page [GT-193] Update css properties for service group
…-site,-services-and-endpoints [GT-141] Add support for pre selecting endpoints
Co-authored-by: ineilson <ian.neilson@stfc.ac.uk>
Fix JS regex use to validate IRIS IAM strings
…ipts - not doing this produces a codacy/codeclimate fail
- to fix code style issues that get flagged by codacy/codeclimate
- lines over 80 characters flag codeclimate fails - this splits up long lines in the deploy directory
- opening parenthesis at end of line - one argument per line - closing parenthesis on own line - indentation fixes - spaces after closing parenthesis before an opening parenthesis - some issue fixes suggested by codeclimate
…ta-deploy-scripts Fix code style issues in sample data deploy scripts
Update ShibToken for Keycloak based EGI Check-in to dev
- Having the line break in the href string cause the spaces to be interpreted as part of the URL. - Add a comment explaining why xecho is used here - factor out $params['user']->getHomeSite() and short name / site id into variables - indentation of "?>" looks a little weird but i guess it makes sense because it's treating the `if` as a reason to increase the indent.
Rework Home Site display
Allow status of GOCDB to be checked without requiring authentication
Add http response code to check.php
Bumps [actions/cache](https://github.com/actions/cache) from 3 to 4. - [Release notes](https://github.com/actions/cache/releases) - [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md) - [Commits](actions/cache@v3...v4) --- updated-dependencies: - dependency-name: actions/cache dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
…cache-4 Bump actions/cache from 3 to 4
Merged
|
Most of the issues are line length related, Codacy is pulling in the fact we care about that for the first time on the master branch (see #468). I also had to (re?)enabled analysis of the master branch, so some of the "new" issues seem to be just long standing issues getting noticed for the "first" time by Codacy. |
tofu-rocketry
approved these changes
Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subject to #505 being reviewed, this PR contains no unreviewed code.