OHRI-2304: failling expression and error rendering field causing L&d form not to save #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alaboso
approved these changes
Jul 25, 2024
lucyjemutai
changed the title
Herobiam
approved these changes
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves two errors;
hiv_test_statusis not defined in the form.Error rendering field Invalid time valuewhen theAlready on ARTis selected... I added a validation thatensures that formatDate(latest_anc_art_start_date) is only executed if
latest_anc_art_start_dateis present .If
latest_anc_art_start_dateis empty, it will return an empty string. This prevents formatting errors