-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add issue-1032
Constraints
#1051
base: develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good nice work
needs rebase |
0e33c1e
to
65a1491
Compare
65a1491
to
6a2034b
Compare
6a2034b
to
bdcc2c9
Compare
87a4270
to
8e5f6c9
Compare
8e5f6c9
to
810cd77
Compare
conflicts need to be resolved |
810cd77
to
b5bc9f7
Compare
done 🫡 |
b5bc9f7
to
156f428
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
yes it looks good but conflicts need to be resolved again |
Committer Notes
Purpose
This PR aims to add the
component-has-authenticated-scan
andinventory-item-has-authenticated-scan
constraints which help ensure that there is an "allow-authenticated-scan" prop in the inventory, and each Internal "service" component has "allows-authenticated-scan".Changes
Added constraints:
component-has-authenticated-scan
inventory-item-has-authenticated-scan
Added valid/invalid test content:
ssp-component-has-authenticated-scan-INVALID.xml
ssp-inventory-item-has-authenticated-scan-INVALID.xml
fedramp-ssp-example.oscal.xml
to align with constraints.Added yaml files for testing:
All Submissions:
By submitting a pull request, you are agreeing to provide this contribution under the CC0 1.0 Universal public domain dedication.