Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Profile fix issue 1102 #1103

Merged
merged 5 commits into from
Jan 16, 2025
Merged

Conversation

Rene2mt
Copy link
Member

@Rene2mt Rene2mt commented Jan 15, 2025

Committer Notes

This PR fixes the reported issue #1102 by:

  • Adding the FedRAMP namespace to any parts added in the FedRAMP (High, Moderate, Low, and LI-SaaS) profiles.
    • This eliminates errors in resolved profiles due to unexpected parts (e.g., `..) in the resolved profile catalogs
    • This makes it easier for consumers of the FedRAMP resolved profile catalogs to identify FedRAMP specific alterations (e.g., Additional FedRAMP requirements and guidance)
  • Fixed duplicate part IDs in High and Moderate profiles.
  • Updated the last-updated, version, and oscal-version in the metadata of the FedRAMP (High, Moderate, Low, and LI-SaaS) profiles.

All Submissions:

By submitting a pull request, you are agreeing to provide this contribution under the CC0 1.0 Universal public domain dedication.

@Rene2mt Rene2mt requested a review from a team as a code owner January 15, 2025 22:42
@Rene2mt Rene2mt linked an issue Jan 15, 2025 that may be closed by this pull request
12 tasks
Gabeblis
Gabeblis previously approved these changes Jan 16, 2025
Copy link
Contributor

@Gabeblis Gabeblis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Gabeblis
Copy link
Contributor

I know this was brought up in conversation before, but per the issue, "Fixes only need to be made to the XML profiles, and will cascade to the all formats (XML, JSON, and YAML) during CI profile resolution and conversion.", are we sure that these changes will cascade to all formats or should we manually apply these changes?

@aj-stein-gsa
Copy link
Contributor

I know this was brought up in conversation before, but per the issue, "Fixes only need to be made to the XML profiles, and will cascade to the all formats (XML, JSON, and YAML) during CI profile resolution and conversion.", are we sure that these changes will cascade to all formats or should we manually apply these changes?

We are going to need to release for this to happen automatically with CI (as that only happens on master branch based on current GitHub Actions configuration) or manually push it into develop. From recollection, you do it enough the latter way manually with a developer committing outside of CD you have some fun, gnarly merge conflicts in some cases. FYI/FYE

aj-stein-gsa
aj-stein-gsa previously approved these changes Jan 16, 2025
Copy link
Contributor

@aj-stein-gsa aj-stein-gsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor feedback, but good to go otherwise. I approve.

@aj-stein-gsa aj-stein-gsa dismissed stale reviews from Gabeblis and themself via f4535ca January 16, 2025 22:29
@aj-stein-gsa aj-stein-gsa merged commit c0df306 into GSA:develop Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resolved profile catalogs generate validation errors
3 participants