Dissipative TEBD #270
Open
Dissipative TEBD #270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #270 +/- ##
==========================================
- Coverage 87.51% 85.85% -1.66%
==========================================
Files 22 22
Lines 2298 2347 +49
==========================================
+ Hits 2011 2015 +4
- Misses 287 332 +45
Continue to review full report at Codecov.
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Comment on lines
+41
to
+42
| op(sites::Vector{<:Index}, O⃗::Tuple{AbstractString,Vararg}...) = | ||
| reduce(*, [op(sites, O) for O in O⃗]) |
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| op(sites::Vector{<:Index}, O⃗::Tuple{AbstractString,Vararg}...) = | |
| reduce(*, [op(sites, O) for O in O⃗]) | |
| function op(sites::Vector{<:Index}, O⃗::Tuple{AbstractString,Vararg}...) | |
| return reduce(*, [op(sites, O) for O in O⃗]) | |
| end |
Comment on lines
+45
to
+48
| sites::Vector{<:Index}, | ||
| f::Function, | ||
| O⃗::Tuple{AbstractString,Vararg}...; | ||
| kwargs... |
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| sites::Vector{<:Index}, | |
| f::Function, | |
| O⃗::Tuple{AbstractString,Vararg}...; | |
| kwargs... | |
| sites::Vector{<:Index}, f::Function, O⃗::Tuple{AbstractString,Vararg}...; kwargs... |
Comment on lines
+54
to
+57
| op(sites::Vector{<:Index}, | ||
| fO⃗::Tuple{Function,<:Tuple}) = | ||
| op(sites, first(fO⃗), last(fO⃗)...) | ||
|
|
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| op(sites::Vector{<:Index}, | |
| fO⃗::Tuple{Function,<:Tuple}) = | |
| op(sites, first(fO⃗), last(fO⃗)...) | |
| function op(sites::Vector{<:Index}, fO⃗::Tuple{Function,<:Tuple}) | |
| return op(sites, first(fO⃗), last(fO⃗)...) | |
| end |
| layer = Tuple[] | ||
| for k in 1:length(H) | ||
| length(H[k]) > 3 && | ||
| error("Only the format (coupling, opname, support) currently allowed") | ||
| coupling, Hdata... = H[k] | ||
| layer = vcat(layer, [(x -> exp(-δτ * coupling * x), Hdata...)]) | ||
| opname = first(Hdata) | ||
| layer = vcat(layer, [(x -> exp(-δτ * coupling * x), Hdata)]) |
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| layer = vcat(layer, [(x -> exp(-δτ * coupling * x), Hdata)]) | |
| layer = vcat(layer, [(x -> exp(-δτ * coupling * x), Hdata)]) |
| rate, opname, site = lindblad | ||
| !(site isa Int) && error("Only single-body lindblad operators allowed") | ||
| s = hilbert[site] | ||
|
|
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
Comment on lines
+85
to
+87
| display(∑) | ||
|
|
||
|
|
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| display(∑) | |
| display(∑) |
Comment on lines
+138
to
+140
| function _trottercircuit(H::Vector{<:Vector{Tuple}}, τs::Vector; layered::Bool = true, lindbladians = [], kwargs...) | ||
| !isempty(lindbladians) && error("Trotter simulation with Lindblad operators requires a set of indices") | ||
| @assert length(H) == (length(τs) -1) || length(H) == length(τs) |
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| function _trottercircuit(H::Vector{<:Vector{Tuple}}, τs::Vector; layered::Bool = true, lindbladians = [], kwargs...) | |
| !isempty(lindbladians) && error("Trotter simulation with Lindblad operators requires a set of indices") | |
| @assert length(H) == (length(τs) -1) || length(H) == length(τs) | |
| function _trottercircuit( | |
| H::Vector{<:Vector{Tuple}}, τs::Vector; layered::Bool=true, lindbladians=[], kwargs... | |
| ) | |
| !isempty(lindbladians) && | |
| error("Trotter simulation with Lindblad operators requires a set of indices") | |
| @assert length(H) == (length(τs) - 1) || length(H) == length(τs) |
Comment on lines
+147
to
+148
| function _trottercircuit(hilbert::Vector{<:Index}, H::Vector{<:Vector{Tuple}}, τs::Vector; layered::Bool = true, kwargs...) | ||
| @assert length(H) == (length(τs) -1) || length(H) == length(τs) |
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| function _trottercircuit(hilbert::Vector{<:Index}, H::Vector{<:Vector{Tuple}}, τs::Vector; layered::Bool = true, kwargs...) | |
| @assert length(H) == (length(τs) -1) || length(H) == length(τs) | |
| function _trottercircuit( | |
| hilbert::Vector{<:Index}, | |
| H::Vector{<:Vector{Tuple}}, | |
| τs::Vector; | |
| layered::Bool=true, | |
| kwargs..., | |
| ) | |
| @assert length(H) == (length(τs) - 1) || length(H) == length(τs) |
Comment on lines
+154
to
+156
|
|
||
| function _trottercircuit(H::Vector{<:Tuple}, τs::Vector; layered::Bool = true, lindbladians = [], kwargs...) | ||
| !isempty(lindbladians) && error("Trotter simulation with Lindblad operators requires a set of indices") |
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| function _trottercircuit(H::Vector{<:Tuple}, τs::Vector; layered::Bool = true, lindbladians = [], kwargs...) | |
| !isempty(lindbladians) && error("Trotter simulation with Lindblad operators requires a set of indices") | |
| function _trottercircuit( | |
| H::Vector{<:Tuple}, τs::Vector; layered::Bool=true, lindbladians=[], kwargs... | |
| ) | |
| !isempty(lindbladians) && | |
| error("Trotter simulation with Lindblad operators requires a set of indices") |
| return reduce(vcat, [layer for _ in 1:nlayers]) | ||
| end | ||
|
|
||
| function _trottercircuit(hilbert::Vector{<:Index}, H::Vector{<:Tuple}, τs::Vector; layered::Bool = true, kwargs...) |
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| function _trottercircuit(hilbert::Vector{<:Index}, H::Vector{<:Tuple}, τs::Vector; layered::Bool = true, kwargs...) | |
| function _trottercircuit( | |
| hilbert::Vector{<:Index}, H::Vector{<:Tuple}, τs::Vector; layered::Bool=true, kwargs... | |
| ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.