Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable using an active run in kedro-mlflow #359

Merged
merged 1 commit into from
Jan 9, 2023

Conversation

Galileo-Galilei
Copy link
Owner

@Galileo-Galilei Galileo-Galilei commented Sep 27, 2022

Description

Close #358, prepare #11 and support getindata/kedro-azureml#9

Development notes

Checklist

  • Read the contributing guidelines
  • Open this PR as a 'Draft Pull Request' if it is work-in-progress
  • Update the documentation to reflect the code changes
  • Add a description of this change and add your name to the list of supporting contributions in the CHANGELOG.md file. Please respect Keep a Changelog guidelines.
  • Add tests to cover your changes

Notice

  • I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":

  • I submit this contribution under the Apache 2.0 license and represent that I am entitled to do so on behalf of myself, my employer, or relevant third parties, as applicable.

  • I certify that (a) this contribution is my original creation and / or (b) to the extent it is not my original creation, I am authorised to submit this contribution on behalf of the original creator(s) or their licensees.

  • I certify that the use of this contribution as authorised by the Apache 2.0 license does not violate the intellectual property rights of anyone else.

Copy link
Collaborator

@takikadiri takikadiri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't test it yet with a real mlflow orchestrator but it looks good to me.

@codecov-commenter
Copy link

codecov-commenter commented Oct 3, 2022

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (38c217d) compared to base (e44fcff).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #359   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           27        27           
  Lines          922       922           
=========================================
  Hits           922       922           
Impacted Files Coverage Δ
kedro_mlflow/framework/hooks/mlflow_hook.py 100.00% <100.00%> (ø)
kedro_mlflow/framework/cli/cli.py 100.00% <0.00%> (ø)
kedro_mlflow/pipeline/pipeline_ml.py 100.00% <0.00%> (ø)
kedro_mlflow/mlflow/kedro_pipeline_model.py 100.00% <0.00%> (ø)
..._mlflow/io/models/mlflow_abstract_model_dataset.py 100.00% <0.00%> (ø)
...lflow/io/metrics/mlflow_abstract_metric_dataset.py 100.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Galileo-Galilei Galileo-Galilei marked this pull request as ready for review January 9, 2023 22:02
@Galileo-Galilei Galileo-Galilei merged commit 503f65c into master Jan 9, 2023
@Galileo-Galilei Galileo-Galilei deleted the 358-use-active-run branch January 9, 2023 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow Running kedro-mlflow projects with an MLflow orchestrator
3 participants