Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

donation V2 touchup #772

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

donation V2 touchup #772

wants to merge 1 commit into from
+516 −766

Conversation

uraniumanchor
Copy link
Collaborator

@uraniumanchor uraniumanchor commented Jan 18, 2025 •
edited
Loading

Contributing to the Donation Tracker

First of all, thank you for taking the time to contribute!

Please fill out the template below and check the following boxes:

  • I've added tests or modified existing tests for the change.
  • I've humanly end-to-end tested the change by running an instance of the tracker.

Issue from Pivotal Tracker

https://www.pivotaltracker.com/story/show/188791783

Description of the Change

Donation API was missing a few things.

  • no way to list donations or search for them unless you knew their exact IDs
  • not nested under the event path
  • various feeds/patch paths will now serialize pending/hidden bids again if requested and the user has permission
  • processing socket (but not the donation broadcast socket) will serialized pending/hidden bids
  • fetchMe in the JS pages uses v2, which means the me endpoint in v1 can go away

Verification Process

Not quite done yet.

@uraniumanchor
donation V2 touchup
bd2dd08 
- better search
- better tests
- better serialization
- anybody on the donation socket is required to have view bid permission
  for incoming pending bids

[#188791783]
@uraniumanchor uraniumanchor marked this pull request as draft January 18, 2025 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@uraniumanchor